Attention is currently required from: Raul Rangel, Matt Papageorge, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52452 )
Change subject: vc/amd/fsp/cezanne: update SMU setting section of FspmUpd.h
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52452/comment/42a0897a_54b2bdf4
PS1, Line 15: very recent build of the FSP binarie
this change isn't included in a fsp drop and i don't think that there will be fsp new drops, so that […]
Right, I was working on stapm changes and noticed this. It won't affect anything until we set the stapm values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If39aaf64e8e1b4c0426f22ce8ed07707c2a31e61
Gerrit-Change-Number: 52452
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 20 Apr 2021 15:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment