Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31076
Change subject: [WIP] Move AGESA and apufw higher in CBFS ......................................................................
[WIP] Move AGESA and apufw higher in CBFS
Increases continuous free space in CBFS from 5.8 MiB to 7.1 MiB.
Will not work with released binaryPI build from 3rdparty/blobs.
Change-Id: I3c166102b8774499a0b21f212b5e8a66fe6c52eb Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/amd/pi/hudson/Makefile.inc M src/vendorcode/amd/pi/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/31076/1
diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc index 81fe7ff..57bad38 100644 --- a/src/southbridge/amd/pi/hudson/Makefile.inc +++ b/src/southbridge/amd/pi/hudson/Makefile.inc @@ -75,7 +75,7 @@ ifeq ($(CONFIG_AMDFW_OUTSIDE_CBFS),y) HUDSON_FWM_POSITION=$(call int-add, $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 0x20000 1) else -HUDSON_FWM_POSITION=0xfff20000 +HUDSON_FWM_POSITION=0xfffa0000 endif
ifeq ($(CONFIG_HUDSON_PSP), y) diff --git a/src/vendorcode/amd/pi/Kconfig b/src/vendorcode/amd/pi/Kconfig index f463b7d..3dc7052 100644 --- a/src/vendorcode/amd/pi/Kconfig +++ b/src/vendorcode/amd/pi/Kconfig @@ -96,7 +96,7 @@
config AGESA_BINARY_PI_LOCATION hex "AGESA PI binary address in ROM" - default 0xFFE00000 + default 0xFFF00000 depends on !AGESA_BINARY_PI_AS_STAGE help Specify the ROM address at which to store the binary Platform
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31076 )
Change subject: [WIP] Move AGESA and apufw higher in CBFS ......................................................................
Patch Set 1:
All the mainboard that use PI Hudson also use binaryPI release builds from 3rdparty blobs. Is there a known and open method to rebase the AGESA binary? Otherwise, I do not see any sense of moving the AGESA binary location to 0xFFF00000
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31076 )
Change subject: [WIP] Move AGESA and apufw higher in CBFS ......................................................................
Patch Set 1:
Patch Set 1:
All the mainboard that use PI Hudson also use binaryPI release builds from 3rdparty blobs. Is there a known and open method to rebase the AGESA binary? Otherwise, I do not see any sense of moving the AGESA binary location to 0xFFF00000
I was never aware of a method for rebasing an AGESA image (i.e. similar to Intel's BCT) or a way to relocate it during the coreboot build process.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31076 )
Change subject: [WIP] Move AGESA and apufw higher in CBFS ......................................................................
Abandoned