Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86393?usp=email )
Change subject: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86393/comment/f908afc5_a4ce8efb?usp... :
PS4, Line 9: This patch avoids exposing CPUJTAG GPIO PADs as these are internal
This patch prevents the exposure of CPU JTAG GPIO pads, as these are
internal GPIO pins used for SoC debugging purposes and should not permit
kernel-level configuration.
File src/soc/intel/pantherlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/86393/comment/5bb3df91_92c783c3?usp... :
PS4, Line 530: /* Don't expose first bank/group in community 3: CPUJTAG because
I believe that it does not comply with coreboot style. Shouldn't it be?
```
/*
* Don't expose first bank/group in community 3: CPUJTAG because
* CPUJTAG doesn't required to be controlled by kernel pinctrl driver.
*/
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86393?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d920acb95275fbf72b83b822eddc41829511626
Gerrit-Change-Number: 86393
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Thu, 13 Feb 2025 23:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No