Change in coreboot[master]: mb/google/volteer/variants/baseboard: Fix the typo for power limit va...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Sumeet R Pawnikar (Code Review)

8 Oct 2020 8 Oct '20

5:48 p.m.

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer/variants/baseboard: Fix the typo for power limit values ......................................................................

mb/google/volteer/variants/baseboard: Fix the typo for power limit values

Fix the typo for power limit values under comment section

BUG=None BRANCH=None TEST=Build for volteer system

Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/46220/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 7790230..a32d711 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -376,8 +376,8 @@ [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}"

## Power Limits Control - # 10-15W PL1 in 200mW increments, avg over 28-32s interval - # PL2 is fixed at 64W, avg over 28-32s interval + # 3-15W PL1 in 200mW increments, avg over 28-32s interval + # PL2 is fixed at 60W, avg over 28-32s interval register "controls.power_limits" = "{ .pl1 = {.min_power = 3000, .max_power = 15000,

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

8 Oct 8 Oct

6:33 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer/variants/baseboard: Fix the typo for power limit values ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46220/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46220/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/variants/baseboard: Fix the typo for power limit values suggestion: mb/google/volteer: Fix typo in baseboard power limits

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 16:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sumeet R Pawnikar (Code Review)

6:51 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Tim Wawrzynczak, Paul Menzel, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46220

to look at the new patch set (#2).

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

mb/google/volteer: Fix typo in baseboard power limits

Fix typo for power limit values under comment section in baseboard

BUG=None BRANCH=None TEST=Build for volteer system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/46220/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

7:18 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46220/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46220/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/variants/baseboard: Fix the typo for power limit values

...

suggestion: mb/google/volteer: Fix typo in baseboard power limits

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 17:18:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:25 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46220/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/46220/2/src/mainboard/google/voltee... PS2, Line 380: is fixed at 60W actually this part changed too 😊 should be "ranges from 15 to 60W"

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 17:25:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sumeet R Pawnikar (Code Review)

7:28 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Tim Wawrzynczak, Paul Menzel, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46220

to look at the new patch set (#3).

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

mb/google/volteer: Fix typo in baseboard power limits

Fix typo for power limit values under comment section in baseboard

BUG=None BRANCH=None TEST=Build for volteer system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/46220/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

7:29 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46220/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/46220/2/src/mainboard/google/voltee... PS2, Line 380: is fixed at 60W

...

actually this part changed too 😊 […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 17:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:34 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 17:34:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12 Oct 12 Oct

10:48 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Fix typo in baseboard power limits

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46220 )

Change subject: mb/google/volteer: Fix typo in baseboard power limits ......................................................................

mb/google/volteer: Fix typo in baseboard power limits

Fix typo for power limit values under comment section in baseboard

BUG=None BRANCH=None TEST=Build for volteer system

Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46220 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index e428588..898b5ae 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -374,8 +374,8 @@ [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}"

## Power Limits Control - # 10-15W PL1 in 200mW increments, avg over 28-32s interval - # PL2 is fixed at 64W, avg over 28-32s interval + # 3-15W PL1 in 200mW increments, avg over 28-32s interval + # PL2 ranges from 15 to 60W, avg over 28-32s interval register "controls.power_limits" = "{ .pl1 = {.min_power = 3000, .max_power = 15000,

-- To view, visit https://review.coreboot.org/c/coreboot/+/46220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879b9587e863360bf4efda4099d96b42b904377e Gerrit-Change-Number: 46220 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1293

days inactive

1297

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Patrick Georgi (Code Review)
Sumeet R Pawnikar (Code Review)
Tim Wawrzynczak (Code Review)