Attention is currently required from: Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85937?usp=email )
Change subject: mb/gogole/brya/var/trulo: Streamlines WP gpio pin configuration
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85937/comment/adb0efaf_a4e61d02?usp... :
PS1, Line 7: mb/google/trulo:
mb/gogole/brya/var/trulo
Acknowledged
https://review.coreboot.org/c/coreboot/+/85937/comment/3d6ed36e_f4b2e17c?usp... :
PS1, Line 12: BUG=b:386741705
please mention the BRANCH details so we don't miss to pull this CL into trulo FW branch
Acknowledged
https://review.coreboot.org/c/coreboot/+/85937/comment/1481b92d_ffd04f0e?usp... :
PS1, Line 13: TEST=Able to build google/truloti
nit, use a `period` at the end of the line
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85937?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3621dfd6b80215a2fe6a468e852189df0bed86a2
Gerrit-Change-Number: 85937
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 13 Jan 2025 05:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com