Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22374 )
Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ......................................................................
Patch Set 42:
(3 comments)
https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_ini... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_ini... PS25, Line 38: __attribute__((weak)) void mrc_cache_update_hash(const uint8_t *data,
Done
Does not compute build issues
https://review.coreboot.org/#/c/22374/39/src/drivers/intel/fsp2_0/memory_ini... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/22374/39/src/drivers/intel/fsp2_0/memory_ini... PS39, Line 38: __attribute__((weak)) void mrc_cache_update_hash(const uint8_t *data,
I assume you're planning to add other methods to store the MRC hash? Otherwise, using a weak functio […]
Yep that was my idea.
https://review.coreboot.org/#/c/22374/39/src/security/tpm/Kconfig File src/security/tpm/Kconfig:
https://review.coreboot.org/#/c/22374/39/src/security/tpm/Kconfig@18 PS39, Line 18:
And now that I think of it, I don't think it really make sense to let the user decide between TPM-1. […]
Now we have both options. User mode for pluggable TPMs and board mode.
-
Philipp Deppenwiese (Code Review)