Change in coreboot[master]: mb/google/hatch: Add FP MCU to helios device tree

[Philip Chen (Code Review)]

Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34465 )

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

mb/google/hatch: Add FP MCU to helios device tree

BUG=b:136606255

Change-Id: I8fa29dc96e7a066f6708ede6b7bee2382c7008cb
---
M src/mainboard/google/hatch/variants/helios/overridetree.cb
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/34465/1

diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb
index 35f8ad5..41c15c8 100644
--- a/src/mainboard/google/hatch/variants/helios/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb
@@ -21,6 +21,7 @@
    #+-------------------+---------------------------+
    #| Field	     |	Value			 |
    #+-------------------+---------------------------+
+	#| GSPI1             | FP MCU                    |
    #| I2C0		     | Trackpad			 |
    #| I2C1		     | Touchscreen		 |
    #| I2C4		     | Audio			 |
@@ -153,5 +154,15 @@
    			device i2c 3b on end
    		end
    	end #I2C #4
+		device pci 1e.3 on
+			chip drivers/spi/acpi
+				register "name" = ""CRFP""
+				register "hid" = "ACPI_DT_NAMESPACE_HID"
+				register "uid" = "1"
+				register "compat_string" = ""google,cros-ec-spi""
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)"
+				device spi 1 on end
+			end # FPMCU
+		end # GSPI #1
    end
 end

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34465 )

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34465/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34465/1//COMMIT_MSG@12 
PS1, Line 12: 
Signed-off-by line?

[Philip Chen (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34465

to look at the new patch set (#2).

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

mb/google/hatch: Add FP MCU to helios device tree

BUG=b:136606255

Change-Id: I8fa29dc96e7a066f6708ede6b7bee2382c7008cb
Signed-off-by: Philip Chen 
---
M src/mainboard/google/hatch/variants/helios/overridetree.cb
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/34465/2

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34465 )

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34465/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34465/1//COMMIT_MSG@12 
PS1, Line 12:
> Signed-off-by line?

Done

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34465 )

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34465 )

Change subject: mb/google/hatch: Add FP MCU to helios device tree
......................................................................

mb/google/hatch: Add FP MCU to helios device tree

BUG=b:136606255

Change-Id: I8fa29dc96e7a066f6708ede6b7bee2382c7008cb
Signed-off-by: Philip Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34465
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/hatch/variants/helios/overridetree.cb
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb
index 35f8ad5..41c15c8 100644
--- a/src/mainboard/google/hatch/variants/helios/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb
@@ -21,6 +21,7 @@
    #+-------------------+---------------------------+
    #| Field	     |	Value			 |
    #+-------------------+---------------------------+
+	#| GSPI1             | FP MCU                    |
    #| I2C0		     | Trackpad			 |
    #| I2C1		     | Touchscreen		 |
    #| I2C4		     | Audio			 |
@@ -153,5 +154,15 @@
    			device i2c 3b on end
    		end
    	end #I2C #4
+		device pci 1e.3 on
+			chip drivers/spi/acpi
+				register "name" = ""CRFP""
+				register "hid" = "ACPI_DT_NAMESPACE_HID"
+				register "uid" = "1"
+				register "compat_string" = ""google,cros-ec-spi""
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)"
+				device spi 1 on end
+			end # FPMCU
+		end # GSPI #1
    end
 end