Attention is currently required from: Tarun Tuli, Dinesh Gehlot.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/8b18fe2f_8ea852c8 PS3, Line 235: DRIVERS_INTEL_ISH if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE) && CONFIG(SOC_INTEL_GET_FIRMWARE_VERSIONS_FROM_CSE))
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/2f5cb3ff_98cb47ed PS3, Line 1087: if (!cse_get_bp_info(&cse_bp_info))
suspect code indent for conditional statements (8, 24)
Please fix.
https://review.coreboot.org/c/coreboot/+/74256/comment/6dceeac6_f60681b5 PS3, Line 1184: ENV_RAMSTAGE if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && CONFIG(SOC_INTEL_GET_FIRMWARE_VERSIONS_FROM_CSE))