HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34933 )
Change subject: src: Remobe unneeded include <arch/interrupt.h> ......................................................................
src: Remobe unneeded include <arch/interrupt.h>
Change-Id: I3323d25b72dab2f9bc8a575ba41faf059ee1ffc4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/intel_ddi.c M src/include/device/azalia_device.h M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/roda/rk886ex/mainboard.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/siemens/mc_bdx1/mainboard.c M src/mainboard/siemens/mc_tcu3/mainboard.c 19 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34933/1
diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 471a5d2..3ab0022 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -33,7 +33,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <arch/acpi.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <smbios.h> #include <device/pci.h> diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index 343e261..cbc5b4e 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -19,7 +19,6 @@ #include <types.h> #include <arch/acpi.h> #include <device/mmio.h> -#include <arch/interrupt.h> #include <device/device.h>
void azalia_audio_init(struct device *dev); diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index 798fc12..52b4f04 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <arch/interrupt.h> #include <northbridge/intel/i945/i945.h> #include <arch/acpigen.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index 7bda2f6..fd74a6e 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <device/device.h> #include <device/pci_def.h> diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index c298689..067ea4e 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -24,7 +24,6 @@ #include <fmap.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include "onboard.h" #include "ec.h" diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c index 8c3ad63..533eb23 100644 --- a/src/mainboard/google/parrot/mainboard.c +++ b/src/mainboard/google/parrot/mainboard.c @@ -21,7 +21,6 @@ #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include "onboard.h" #include "ec.h" diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index b98fc8a..e40d722 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -22,7 +22,6 @@ #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 05de8cb..ac35602 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -20,7 +20,6 @@ #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/bd82x6x/pch.h> #include <device/pci.h> diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c index 49e66bf..6b10bb4 100644 --- a/src/mainboard/intel/baskingridge/mainboard.c +++ b/src/mainboard/intel/baskingridge/mainboard.c @@ -21,7 +21,6 @@ #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/bayleybay_fsp/mainboard.c b/src/mainboard/intel/bayleybay_fsp/mainboard.c index 16c1844..991e851a 100644 --- a/src/mainboard/intel/bayleybay_fsp/mainboard.c +++ b/src/mainboard/intel/bayleybay_fsp/mainboard.c @@ -21,7 +21,6 @@ #if CONFIG(VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/interrupt.h> #include <boot/coreboot_tables.h>
/* diff --git a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c index ee9f36e..4bd71bf 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c +++ b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c @@ -21,7 +21,6 @@ #if CONFIG(VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/interrupt.h> #include <boot/coreboot_tables.h>
/* diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c index d07da83..848f6de 100644 --- a/src/mainboard/intel/emeraldlake2/mainboard.c +++ b/src/mainboard/intel/emeraldlake2/mainboard.c @@ -20,7 +20,6 @@ #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/bd82x6x/pch.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c index 4bfd039..21321ac 100644 --- a/src/mainboard/intel/wtm2/mainboard.c +++ b/src/mainboard/intel/wtm2/mainboard.c @@ -21,7 +21,6 @@ #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 73d5997..85b704e 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -21,7 +21,6 @@ #include <drivers/intel/gma/int15.h> #include <pc80/mc146818rtc.h> #include <arch/io.h> -#include <arch/interrupt.h>
/* Hardware Monitor */
diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index 785e6e8..508488a 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -25,7 +25,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <ec/acpi/ec.h> #include <drivers/intel/gma/int15.h> -#include <arch/interrupt.h> #include <pc80/keyboard.h> #include <cpu/x86/lapic.h> #include <device/pci.h> diff --git a/src/mainboard/roda/rk886ex/mainboard.c b/src/mainboard/roda/rk886ex/mainboard.c index 91c11d5..922eba2 100644 --- a/src/mainboard/roda/rk886ex/mainboard.c +++ b/src/mainboard/roda/rk886ex/mainboard.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <device/device.h> #include <arch/io.h> -#include <arch/interrupt.h> #include <drivers/intel/gma/int15.h> #include <ec/acpi/ec.h>
diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c index 8664217..893830e 100644 --- a/src/mainboard/samsung/lumpy/mainboard.c +++ b/src/mainboard/samsung/lumpy/mainboard.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <ec/smsc/mec1308/ec.h> #include "ec.h" diff --git a/src/mainboard/siemens/mc_bdx1/mainboard.c b/src/mainboard/siemens/mc_bdx1/mainboard.c index 2bb9852..5cef53c 100644 --- a/src/mainboard/siemens/mc_bdx1/mainboard.c +++ b/src/mainboard/siemens/mc_bdx1/mainboard.c @@ -27,7 +27,6 @@ #include <x86emu/x86emu.h> #endif #include <device/mmio.h> -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <hwilib.h> #include <i210.h> diff --git a/src/mainboard/siemens/mc_tcu3/mainboard.c b/src/mainboard/siemens/mc_tcu3/mainboard.c index 169b04d..a50a53e 100644 --- a/src/mainboard/siemens/mc_tcu3/mainboard.c +++ b/src/mainboard/siemens/mc_tcu3/mainboard.c @@ -22,7 +22,6 @@ #if CONFIG(VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <hwilib.h> #include <i210.h>
Hello Evgeny Zinoviev, Werner Zeh, Patrick Rudolph, Huang Jin, Philipp Deppenwiese,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34933
to look at the new patch set (#2).
Change subject: src: Remove unneeded include <arch/interrupt.h> ......................................................................
src: Remove unneeded include <arch/interrupt.h>
Change-Id: I3323d25b72dab2f9bc8a575ba41faf059ee1ffc4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/intel_ddi.c M src/include/device/azalia_device.h M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/roda/rk886ex/mainboard.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/siemens/mc_bdx1/mainboard.c M src/mainboard/siemens/mc_tcu3/mainboard.c 19 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34933/2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34933 )
Change subject: src: Remove unneeded include <arch/interrupt.h> ......................................................................
Patch Set 2: Code-Review+2
-
HAOUAS Elyes (Code Review) -
Werner Zeh (Code Review)