Attention is currently required from: Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email )
Change subject: soc/amd/mendocino: Add DBG2 table
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79174/comment/38446473_058f0105 :
PS2, Line 9: 240426142
303689867
Done
File src/soc/amd/mendocino/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/79174/comment/d7b71bfd_772b9ac6 :
PS2, Line 30: Add table
DBG2?
Done
https://review.coreboot.org/c/coreboot/+/79174/comment/780ba198_85bddfaf :
PS2, Line 31: 0xfedc9000
I would probably use the configured console: […]
Done.
There is not field for baudrate in DBG2.
https://review.coreboot.org/c/coreboot/+/79174/comment/7e156622_a6924470 :
PS2, Line 31: current = acpi_16550_write_dbg2_uart(rsdp, current, 0xfedc9000, NULL);
shouldn't this call be put into an if CONFIG(AMD_SOC_CONSOLE_UART) block? i agree with Raul that the […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2
Gerrit-Change-Number: 79174
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 23 Nov 2023 07:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment