Change in coreboot[master]: [TEST] arch/x86: fail on selected GENERATE_MP_TABLE without mptable.c

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Held (Code Review)

19 Jun 2020 19 Jun '20

9:37 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42572 )

Change subject: [TEST] arch/x86: fail on selected GENERATE_MP_TABLE without mptable.c ......................................................................

[TEST] arch/x86: fail on selected GENERATE_MP_TABLE without mptable.c

Always add mptable.c to ramstage if GENERATE_MP_TABLE is selected in Kconfig.

This is a test to see which boards fail. If some fail, I'll fix those and rebase this patch on top of the fix.

Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42572/1

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 6297384..1674b76 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -281,10 +281,8 @@

ramstage-srcs += $(wildcard src/mainboard/$(MAINBOARDDIR)/mainboard.c) ifeq ($(CONFIG_GENERATE_MP_TABLE),y) -ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/mptable.c),) ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mptable.c endif -endif ifeq ($(CONFIG_GENERATE_PIRQ_TABLE),y) ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/irq_tables.c endif

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Felix Held (Code Review)

19 Jun 19 Jun

10:56 p.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42572

to look at the new patch set (#2).

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

This make the build fail if a board selects GENERATE_MP_TABLE, but doesn't have a mptable.c.

Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42572/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

11:17 p.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42572 )

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/42572/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42572/2//COMMIT_MSG@9 PS2, Line 9: make makes

https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc@2... PS2, Line 284: ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mptable.c How about having boards specify where the mptable.c file is? It would work well with variants stuff

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Jun 2020 21:17:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

11:19 p.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42572 )

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc@2... PS2, Line 284: ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mptable.c

...

How about having boards specify where the mptable. […]

that's probably the way to go there and would allow to fix the 2 variants of that one asus board. might look into that on the weekend

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Jun 2020 21:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Felix Held (Code Review)

20 Jun 20 Jun

2:20 a.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42572

to look at the new patch set (#3).

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

This make the build fail if a board selects GENERATE_MP_TABLE, but doesn't have a mptable.c.

Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42572/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Held (Code Review)

2:45 a.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42572

to look at the new patch set (#4).

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

This make the build fail if a board selects GENERATE_MP_TABLE, but doesn't have a mptable.c.

Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42572/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Held (Code Review)

3:12 a.m.

New subject: Change in coreboot[master]: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42572 )

Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected ......................................................................

Abandoned

turns out that this was intended behaviour

-- To view, visit https://review.coreboot.org/c/coreboot/+/42572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6 Gerrit-Change-Number: 42572 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1774

days inactive

1775

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Felix Held (Code Review)