Change in coreboot[master]: include/acpi/acpi.h: Add LEGACY_DSDT_REV macro

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

28 Sep 2020 28 Sep '20

1:14 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add LEGACY_DSDT_REV macro ......................................................................

include/acpi/acpi.h: Add LEGACY_DSDT_REV macro

Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/emulation/qemu-i440fx/dsdt.asl M src/mainboard/emulation/qemu-q35/dsdt.asl 3 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45786/1

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index d190344..50d8d70 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -42,6 +42,7 @@ #define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */ #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */ +#define LEGACY_DSDT_REV 0x01 /* DSDT revision: ACPI v1 */

#if !defined(__ASSEMBLER__) && !defined(__ACPI__) #include <commonlib/helpers.h> diff --git a/src/mainboard/emulation/qemu-i440fx/dsdt.asl b/src/mainboard/emulation/qemu-i440fx/dsdt.asl index 5a341b4..4bc3df2 100644 --- a/src/mainboard/emulation/qemu-i440fx/dsdt.asl +++ b/src/mainboard/emulation/qemu-i440fx/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "dsdt.aml", // Output Filename "DSDT", // Signature - 0x01, // DSDT Compliance Revision + LEGACY_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x1 // OEM Revision diff --git a/src/mainboard/emulation/qemu-q35/dsdt.asl b/src/mainboard/emulation/qemu-q35/dsdt.asl index a9c96be..d69384c 100644 --- a/src/mainboard/emulation/qemu-q35/dsdt.asl +++ b/src/mainboard/emulation/qemu-q35/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock ( "dsdt.aml", // Output Filename "DSDT", // Signature - 0x01, // DSDT Compliance Revision + LEGACY_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x2 // OEM Revision

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

HAOUAS Elyes (Code Review)

1 Oct 1 Oct

2:25 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_LEGACY_DSDT_REV macro

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45786

to look at the new patch set (#2).

Change subject: include/acpi/acpi.h: Add ACPI_LEGACY_DSDT_REV macro ......................................................................

include/acpi/acpi.h: Add ACPI_LEGACY_DSDT_REV macro

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45786/2

HAOUAS Elyes (Code Review)

2:52 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45786

to look at the new patch set (#3).

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45786/3

Werner Zeh (Code Review)

3:56 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG@7 PS3, Line 7: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro Would you please mention that you touch the two mianboards in this commit as well? Or even better: Split it into two commits?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 01 Oct 2020 13:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:54 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Hello build bot (Jenkins), Nico Huber, Werner Zeh, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45786

to look at the new patch set (#4).

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45786/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:55 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG@7 PS3, Line 7: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

...

Would you please mention that you touch the two mianboards in this commit as well? Or even better: S […]

Done Thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 01 Oct 2020 14:55:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com Gerrit-MessageType: comment

Werner Zeh (Code Review)

2 Oct 2 Oct

6:22 a.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 02 Oct 2020 04:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

13 Oct 13 Oct

7:47 a.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45786/7/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/45786/7/src/include/acpi/acpi.h@45 PS7, Line 45: #define ACPI_DSDT_REV_1 0x01 /* DSDT revision: ACPI v1 */ I'd order this before REV_2, what do you think?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Oct 2020 05:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:53 a.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 7:

(1 comment)

Thank you

https://review.coreboot.org/c/coreboot/+/45786/7/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/45786/7/src/include/acpi/acpi.h@45 PS7, Line 45: #define ACPI_DSDT_REV_1 0x01 /* DSDT revision: ACPI v1 */

...

I'd order this before REV_2, what do you think?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Oct 2020 05:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:54 a.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Hello build bot (Jenkins), Nico Huber, Werner Zeh, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45786

to look at the new patch set (#8).

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45786/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

7:33 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Oct 2020 17:33:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

7:34 p.m.

New subject: Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45786 )

Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro ......................................................................

include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro

Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45786 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 7b0f339..a9ec077 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -41,6 +41,7 @@

#define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */ +#define ACPI_DSDT_REV_1 0x01 /* DSDT revision: ACPI v1 */ #define ACPI_DSDT_REV_2 0x02 /* DSDT revision: ACPI v2.0 and greater */

#if !defined(__ASSEMBLER__) && !defined(__ACPI__)

-- To view, visit https://review.coreboot.org/c/coreboot/+/45786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb Gerrit-Change-Number: 45786 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1556

days inactive

1571

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Werner Zeh (Code Review)