Change in ...coreboot[master]: src/mainboard/asus/am1i-a/buildOpts.c: guard UMA-related options by C...

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Mike Banon (Code Review)

30 Jun 2019 30 Jun '19

3:55 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33916

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA ......................................................................

src/mainboard/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA

Seems this guard has been accidentally removed during the creation of this file.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/33916/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 2a1f13d..dfd27cd 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -176,9 +176,11 @@ #define BLDCFG_VRM_NB_MAXIMUM_CURRENT_LIMIT 17000 #define BLDCFG_VRM_NB_SVI_OCP_LEVEL BLDCFG_VRM_NB_MAXIMUM_CURRENT_LIMIT

+#if CONFIG(GFXUMA) #define BLDCFG_UMA_ALIGNMENT UMA_4MB_ALIGNED #define BLDCFG_UMA_ALLOCATION_MODE UMA_AUTO #define OPTION_GFX_INIT_SVIEW FALSE +#endif

#define BLDCFG_PCIE_TRAINING_ALGORITHM PcieTrainingDistributed

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Mike Banon (Code Review)

30 Jun 30 Jun

5:32 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA ......................................................................

Patch Set 1:

am1i-a/buildOpts.c patch series [4/8] : 1st = CB:33913 , 2nd = CB:33914 , 3rd = CB:33915 ; 4th = CB:33916 <-- you are here ; 5th = CB:33917 , 6th = CB:33918 , 7th = CB:33919 , 8th = CB:33920

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 30 Jun 2019 15:32:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

9 Apr 9 Apr

3:33 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33916

to look at the new patch set (#6).

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA ......................................................................

mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA

Seems this guard has been accidentally removed during the creation of this file.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/33916/6

Mike Banon (Code Review)

5:45 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA ......................................................................

Patch Set 6:

Same SHA256 when built with "make BUILD_TIMELESS=1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 15:45:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10 Apr 10 Apr

1:34 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options by CONFIG_GFXUMA ......................................................................

Patch Set 6: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG@7 PS6, Line 7: by with

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG@9 PS6, Line 9: Seems this guard has been accidentally removed during the creation of this file. So as to be below the 72-character limit, how about:

Looks like the guard was dropped by mistake.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 23:34:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

11 Apr 11 Apr

9:24 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33916

to look at the new patch set (#8).

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA ......................................................................

mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Looks like the guard was dropped by mistake.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/33916/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

9:25 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG@7 PS6, Line 7: by

...

with

Done.

https://review.coreboot.org/c/coreboot/+/33916/6//COMMIT_MSG@9 PS6, Line 9: Seems this guard has been accidentally removed during the creation of this file.

...

So as to be below the 72-character limit, how about: […]

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Apr 2020 07:25:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michał Żygowski (Code Review)

17 Apr 17 Apr

4:41 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 9 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 14:41:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Apr 20 Apr

8:24 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33916 )

Change subject: mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA ......................................................................

mb/asus/am1i-a/buildOpts.c: guard UMA-related options with CONFIG_GFXUMA

Looks like the guard was dropped by mistake.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33916 Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 40950f6..71b1815f 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -165,9 +165,11 @@ #define BLDCFG_VRM_NB_MAXIMUM_CURRENT_LIMIT 17000 #define BLDCFG_VRM_NB_SVI_OCP_LEVEL BLDCFG_VRM_NB_MAXIMUM_CURRENT_LIMIT

+#if CONFIG(GFXUMA) #define BLDCFG_UMA_ALIGNMENT UMA_4MB_ALIGNED #define BLDCFG_UMA_ALLOCATION_MODE UMA_AUTO #define OPTION_GFX_INIT_SVIEW FALSE +#endif

#define BLDCFG_PCIE_TRAINING_ALGORITHM PcieTrainingDistributed

-- To view, visit https://review.coreboot.org/c/coreboot/+/33916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie73c4d6cb557820ae7427fef15ca8110722c5b68 Gerrit-Change-Number: 33916 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1678

days inactive

1973

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Michał Żygowski (Code Review)
Mike Banon (Code Review)
Patrick Georgi (Code Review)