Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42604 )
Change subject: mb/asus/p2b: provide MP_TABLE_FILE location ......................................................................
mb/asus/p2b: provide MP_TABLE_FILE location
With this change the build system finds and uses the mptable.c files in their location in the variant's directory.
Change-Id: I7b304dfdba9840f0333b31d9849ecd5d637c06ff Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/asus/p2b/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42604/1
diff --git a/src/mainboard/asus/p2b/Kconfig b/src/mainboard/asus/p2b/Kconfig index 00295be..97ba509 100644 --- a/src/mainboard/asus/p2b/Kconfig +++ b/src/mainboard/asus/p2b/Kconfig @@ -57,4 +57,8 @@ default 7 if BOARD_ASUS_P2B_F || BOARD_ASUS_P2B_DS default 6
+config MP_TABLE_FILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/$(CONFIG_VARIANT_DIR)/mptable.c" + endif
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42604 )
Change subject: mb/asus/p2b: provide MP_TABLE_FILE location ......................................................................
Patch Set 1:
let's see if Jenkins likes this one or if CB:42572 still fails
Hello Keith Hui, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42604
to look at the new patch set (#2).
Change subject: mb/asus/p2b: provide empty mptable.c where build system expects it ......................................................................
mb/asus/p2b: provide empty mptable.c where build system expects it
Two of the variants of asus/p2b have their own mptable.c file in the variant folders that get conditionally added in the board's Makefile.inc, but since the build system expects a mptable.c in the root directory of the board, add an empty file there, so the build system is happy and the locak Makefile.inc can still provide the variant-specific mptable.c.
Change-Id: I7b304dfdba9840f0333b31d9849ecd5d637c06ff Signed-off-by: Felix Held felix-coreboot@felixheld.de --- A src/mainboard/asus/p2b/mptable.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42604/2
Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42604 )
Change subject: mb/asus/p2b: provide empty mptable.c where build system expects it ......................................................................
Abandoned
-
Felix Held (Code Review)