Attention is currently required from: Bincai Liu, Hung-Te Lin, Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85949?usp=email )
Change subject: soc/mediatek/mt8196: Add eDP driver ......................................................................
Patch Set 6:
(10 comments)
File src/soc/mediatek/mt8196/dp_intf.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/949eac59_41bc0a10?usp... : PS6, Line 32: const struct mtk_dvo_sync_param *sync) exceed 96 characters
File src/soc/mediatek/mt8196/dptx.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/0393baea_e127edad?usp... : PS6, Line 260: 0x1f 0x1F
https://review.coreboot.org/c/coreboot/+/85949/comment/29fed030_df07e820?usp... : PS6, Line 272: 0xbf 0xBF
https://review.coreboot.org/c/coreboot/+/85949/comment/9764ad9f_e4dd9387?usp... : PS6, Line 376: int mtk_edp_init(struct mtk_dp *mtk_dp,struct edid *edid)
`space required after that ',' (ctx:VxV)`
Please fix.
https://review.coreboot.org/c/coreboot/+/85949/comment/f809fa33_8f6cec70?usp... : PS6, Line 384: mdelay are you sure this delay it correct ?
File src/soc/mediatek/mt8196/dptx_hal.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/cc740550_82131c5b?usp... : PS4, Line 39: 0xA << 2
0x28
`mtk_dp_mask(mtk_dp, REG_3F28_DP_ENC_4P_3, 0xA << 2, GENMAKS(5, 2));`
File src/soc/mediatek/mt8196/dptx_hal.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/e7731b24_908d8375?usp... : PS6, Line 316: mdelay why does it take a long time ?
https://review.coreboot.org/c/coreboot/+/85949/comment/63eeb49f_926d7d4a?usp... : PS6, Line 338: mdelay why does it take a long time ?
File src/soc/mediatek/mt8196/include/soc/dp_intf.h:
https://review.coreboot.org/c/coreboot/+/85949/comment/7c87787d_50ab5cee?usp... : PS6, Line 137: 0x6c 0x6C
https://review.coreboot.org/c/coreboot/+/85949/comment/ec87d085_f28d84ff?usp... : PS6, Line 141: c C
-
Yidi Lin (Code Review)