[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions - coreboot-gerrit

16 Sep 2024


      Attention is currently required from: Anil Kumar K, Bora Guvendik, Felix Held, Hannah Williams, Jamie Ryu, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )
Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................
Patch Set 21:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/84104/comment/cd8caa28_40122182?usp... :
PS11, Line 241: gpe0_mask
...
...
...
@subratabanik@google.com   I do not see use case for pmc_enable_std_gpe and pmc_disable_std_gpe. […]
sure. on my list.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d
Gerrit-Change-Number: 84104
Gerrit-PatchSet: 21
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 16 Sep 2024 18:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hannah Williams hannah.williams@intel.com
Comment-In-Reply-To: Cliff Huang cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de