Change in ...coreboot[master]: mb/intel/{galileo,wtm2}: Use macro instead of magic number

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33438

Change subject: mb/intel/{galileo,wtm2}: Use macro instead of magic number
......................................................................

mb/intel/{galileo,wtm2}: Use macro instead of magic number

Change-Id: Ib8a08e9f854b2b0786c69943d6dbb66abe3ad4d8
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/intel/galileo/acpi_tables.c
M src/mainboard/intel/wtm2/fadt.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33438/1

diff --git a/src/mainboard/intel/galileo/acpi_tables.c b/src/mainboard/intel/galileo/acpi_tables.c
index 78b05ab..bba8ced 100644
--- a/src/mainboard/intel/galileo/acpi_tables.c
+++ b/src/mainboard/intel/galileo/acpi_tables.c
@@ -26,7 +26,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 5;
+	header->revision = ACPI_FADT_REV_ACPI_5_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c
index a7c6536..7d9096c 100644
--- a/src/mainboard/intel/wtm2/fadt.c
+++ b/src/mainboard/intel/wtm2/fadt.c
@@ -24,7 +24,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 5;
+	header->revision = ACPI_FADT_REV_ACPI_5_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33438 )

Change subject: mb/intel/{galileo,wtm2}: Use macro instead of magic number
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: mb/intel/{galileo,wtm2}: Use macro instead of magic number

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33438 )

Change subject: mb/intel/{galileo,wtm2}: Use macro instead of magic number
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/intel/{galileo,wtm2}: Use macro instead of magic number

[Name of user not set (Code Review)]

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33438 )

Change subject: mb/intel/{galileo,wtm2}: Use macro instead of magic number
......................................................................

Patch Set 2: Code-Review+1

The same I did here previously: CB:35539
Please review it as well

Change in coreboot[master]: mb/intel/{galileo,wtm2}: Use macro instead of magic number

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33438 )

Change subject: mb/intel/{galileo,wtm2}: Use macro instead of magic number
......................................................................

mb/intel/{galileo,wtm2}: Use macro instead of magic number

Change-Id: Ib8a08e9f854b2b0786c69943d6dbb66abe3ad4d8
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33438
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/intel/galileo/acpi_tables.c
M src/mainboard/intel/wtm2/fadt.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Name of user not set #1002476: Looks good to me, but someone else must approve

diff --git a/src/mainboard/intel/galileo/acpi_tables.c b/src/mainboard/intel/galileo/acpi_tables.c
index 78b05ab..bba8ced 100644
--- a/src/mainboard/intel/galileo/acpi_tables.c
+++ b/src/mainboard/intel/galileo/acpi_tables.c
@@ -26,7 +26,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 5;
+	header->revision = ACPI_FADT_REV_ACPI_5_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c
index a7c6536..7d9096c 100644
--- a/src/mainboard/intel/wtm2/fadt.c
+++ b/src/mainboard/intel/wtm2/fadt.c
@@ -24,7 +24,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 5;
+	header->revision = ACPI_FADT_REV_ACPI_5_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);