Change in coreboot[master]: mainboard/google/hatch: Bump MAX_CPU from 8->12

[Edward O'Callaghan (Code Review)]

Hello Edward O'Callaghan,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37725

to review the following change.

Change subject: mainboard/google/hatch: Bump MAX_CPU from 8->12
......................................................................

mainboard/google/hatch: Bump MAX_CPU from 8->12

Some variants like Puff can have up to 12 cores. coreboot should take
the min() where MAX_CPU is the upper bound.

BRANCH=none
BUG=b:146255011
TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I284d027886f662ebb8414ea92540916ed19bc797
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37725/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 98a0174..9200f0f 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -100,7 +100,7 @@

config MAX_CPUS
    int
-	default 8
+	default 12

config OVERRIDE_DEVICETREE
    string

[Kangheui Won (Code Review)]

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: mainboard/google/hatch: Bump MAX_CPU from 8->12
......................................................................

Patch Set 1: Code-Review+1

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: mainboard/google/hatch: Bump MAX_CPU from 8->12
......................................................................

Patch Set 1: Code-Review-1

I would like to see this tested and if it is actually needed for Puff before proceeding.

Change in coreboot[master]: src/soc/intel/connonlake: Bump MAX_CPU from 8->12

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/connonlake: Bump MAX_CPU from 8->12
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37725/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37725/2//COMMIT_MSG@7 
PS2, Line 7: connonlake
cannonlake

Change in coreboot[master]: src/soc/intel/connonlake: Bump MAX_CPU from 8->12

[Mathew King (Code Review)]

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/connonlake: Bump MAX_CPU from 8->12
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

[Mathew King (Code Review)]

Mathew King has uploaded a new patch set (#3) to the change originally created by Edward O'Callaghan. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12
......................................................................

src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

This impacts boards:
 hatch (&variants) and drallion.

Some variants like Puff can have up to 12 cores. coreboot should take
the min() where MAX_CPU is the upper bound.

Further to that, boards themseleves shouldn't be setting the MAX_CPUS,
the chipset should be and so do that.

BRANCH=none
BUG=b:146255011
TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I284d027886f662ebb8414ea92540916ed19bc797
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/soc/intel/cannonlake/Kconfig
3 files changed, 4 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37725/3

Change in coreboot[master]: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/37725/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37725/2//COMMIT_MSG@7 
PS2, Line 7: connonlake
> cannonlake

Done

Change in coreboot[master]: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37725 )

Change subject: src/soc/intel/cannonlake: Bump MAX_CPU from 8->12
......................................................................

src/soc/intel/cannonlake: Bump MAX_CPU from 8->12

This impacts boards:
 hatch (&variants) and drallion.

Some variants like Puff can have up to 12 cores. coreboot should take
the min() where MAX_CPU is the upper bound.

Further to that, boards themseleves shouldn't be setting the MAX_CPUS,
the chipset should be and so do that.

BRANCH=none
BUG=b:146255011
TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I284d027886f662ebb8414ea92540916ed19bc797
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37725
Tested-by: build bot (Jenkins) 
Reviewed-by: EricR Lai 
Reviewed-by: Shelley Chen 
Reviewed-by: Mathew King 
---
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/soc/intel/cannonlake/Kconfig
3 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Shelley Chen: Looks good to me, approved
  EricR Lai: Looks good to me, approved
  Mathew King: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig
index fd7b6b1..e9e26a3 100644
--- a/src/mainboard/google/drallion/Kconfig
+++ b/src/mainboard/google/drallion/Kconfig
@@ -71,10 +71,6 @@
    string
    default "Drallion" if BOARD_GOOGLE_DRALLION

-config MAX_CPUS
-	int
-	default 8
-
 config UART_FOR_CONSOLE
    int
    default 0 if BOARD_GOOGLE_DRALLION
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 98a0174..dff5273 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -98,10 +98,6 @@
    default "Puff" if BOARD_GOOGLE_PUFF
    default "Stryke" if BOARD_GOOGLE_STRYKE

-config MAX_CPUS
-	int
-	default 8
-
 config OVERRIDE_DEVICETREE
    string
    default "variants/helios_diskswap/overridetree.cb" if BOARD_GOOGLE_HELIOS_DISKSWAP
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig
index 6d635ad..8820508 100644
--- a/src/soc/intel/cannonlake/Kconfig
+++ b/src/soc/intel/cannonlake/Kconfig
@@ -108,6 +108,10 @@
    select FSP_T_XIP if FSP_CAR
    select HECI_DISABLE_USING_SMM if !SOC_INTEL_COFFEELAKE && !SOC_INTEL_WHISKEYLAKE && !SOC_INTEL_COMETLAKE

+config MAX_CPUS
+	int
+	default 12
+
 config DCACHE_RAM_BASE
    default 0xfef00000