Change in ...coreboot[master]: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [TRY]...

mikeb mikeb (Code Review)

17 Feb 2019 17 Feb '19

6:20 p.m.

Hello Mike Banon,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to review the following change.

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Make it possible to enable CONFIG_MULTIPLE_VGA_ADAPTERS option for G505S which is currently not used by any of coreboot-supported boards. Also enable the discrete graphics PCI bus leading to HD 8570M (1002,6663) or R5 M230 (1002,6665) discrete VGA and add the G505S-specific workaround for PCI resource allocation problems to AMD AGESA vendorcode.

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/devicetree.cb M src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c 3 files changed, 17 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/1

diff --git a/src/device/Kconfig b/src/device/Kconfig index 33c1e5b3..5d2087e 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -247,8 +247,15 @@ Enable this option for a good compromise between security and speed.

config MULTIPLE_VGA_ADAPTERS + prompt "Multiple VGA Adapters" bool + depends on BOARD_LENOVO_G505S default n + help + Some motherboards may have more than one VGA adapter - for example, + there are versions of Lenovo G505S that have a discrete VGA adapter + in addition to its' integrated VGA adapter which is a part of APU. + Enable this option to try to initialize this discrete VGA adapter.

menu "Display" depends on HAVE_VGA_TEXT_FRAMEBUFFER || HAVE_LINEAR_FRAMEBUFFER diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb index 99f42d6..1f33c27 100644 --- a/src/mainboard/lenovo/g505s/devicetree.cb +++ b/src/mainboard/lenovo/g505s/devicetree.cb @@ -27,7 +27,7 @@ device pci 0.2 on end # IOMMU device pci 1.0 on end # Internal Graphics P2P bridge 0x99XX device pci 1.1 on end # Internal Multimedia - device pci 2.0 off end + device pci 2.0 on end # Discrete Graphics PCI bus 0x666X device pci 3.0 off end device pci 4.0 on end # PCIE MINI0 device pci 5.0 on end # PCIE MINI1 diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c index c566061..ee6d2c2 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c @@ -437,8 +437,15 @@ RefPtr = MemPtr->ParameterListPtr;

// Memory Map/Mgt. - // Mask Bottom IO with 0xF8 to force hole size to have granularity of 128MB - RefPtr->BottomIo = 0xE0; + if ((IS_ENABLED(CONFIG_BOARD_LENOVO_G505S)) && + (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS))) { + // Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems + RefPtr->BottomIo = 0xD0; + } + else { + // Mask Bottom IO with 0xF8 to force hole size to have granularity of 128MB + RefPtr->BottomIo = 0xE0; + } RefPtr->UmaMode = UserOptions.CfgUmaMode; RefPtr->UmaSize = UserOptions.CfgUmaSize; RefPtr->MemHoleRemapping = TRUE;

Attachments:

attachment.htm (text/html — 6.2 KB)

Show replies by date

Kyösti Mälkki (Code Review)

17 Feb 17 Feb

6:27 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31450/1/src/device/Kconfig File src/device/Kconfig:

https://review.coreboot.org/#/c/31450/1/src/device/Kconfig@252 PS1, Line 252: depends on BOARD_LENOVO_G505S We probably will not accept 'depends on BOARD_x' lines in global Kconfig files.

https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... File src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:

https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... PS1, Line 441: (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS))) { We should not inject CONFIG_ stuff to vendorcode. I know they might be some, but should be avoided.

Also, this BottomIo should be settable from coreboot proper, from inside AMD_INIT_POST, seems to be one of AMD_POST_PARAMS structure.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 1 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Sun, 17 Feb 2019 17:27:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

18 Feb 18 Feb

6:48 a.m.

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#2).

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/devicetree.cb M src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c 4 files changed, 23 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/2

mikeb mikeb (Code Review)

8:16 a.m.

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#3).

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/OemCustomize.c M src/mainboard/lenovo/g505s/devicetree.cb 4 files changed, 18 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/3

build bot (Jenkins) (Code Review)

8:17 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 213: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 07:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

9:04 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 212: if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) { Can't you autodetect this at runtime ? All other thinkpads have a GPIO to indicate presence for dGPU.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 08:04:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

9:33 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 212: if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) {

...

Can't you autodetect this at runtime ? […]

you can also enable and configure the bus to see if you can find a VGA behind it. IMO you should just unconditionally set 0xd0, unless you really care about 32bit OS, without PAE.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 08:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

mikeb mikeb (Code Review)

2:01 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/31450/1/src/device/Kconfig File src/device/Kconfig:

https://review.coreboot.org/#/c/31450/1/src/device/Kconfig@252 PS1, Line 252: depends on BOARD_LENOVO_G505S

...

We probably will not accept 'depends on BOARD_x' lines in global Kconfig files.

Done.

https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... File src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:

https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... PS1, Line 441: (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS))) {

...

We should not inject CONFIG_ stuff to vendorcode. I know they might be some, but should be avoided. […]

Thank you for instructions, moved to g505s/OemCustomize.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 13:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

mikeb mikeb (Code Review)

2:45 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 212: if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) {

...

you can also enable and configure the bus to see if you can find a VGA behind it. […]

Luckily it turned out that we could set BottomIo to 0xD0 instead of 0xE0 at G505S "no-dGPU-version" (LA-A092P motherboard) also - without any problems! See /r/QubesN00b report at https://www.reddit.com/r/coreboot/comments/ar8v7d/if_your_g505s_does_not_hav... , he flashed a dGPU build to his "no-dGPU" G505S and everything seems to be working fine for him :D

So a bit later today I am going to remove this "if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) {" condition, and maybe some other conditions like this one (need to re-check if there are any...)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 13:45:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

3:59 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

https://www.informaticanapoli.it/download/SCHEMIELETTRICI/IBM-LENOVO/lenovo....

GPIO59 can be used to detect presence of DGPU.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 14:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

4:22 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 3:

...

Patch Set 3:

GPIO59 can be used to detect presence of DGPU.

Sorry but G505 and G505S are different laptops, here is a correct datasheet for G505S - LA-A091P motherboard - http://www.s-manuals.com/pdf/motherboard/compal/compal_la-a091p_r1.0_schemat... . I don't know how to find a correct GPIO there... but it is not necessary anymore: see comment above, it turned out we could set BottomIO to 0xD0 for all G505S

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 15:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

8:19 p.m.

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#4).

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/OemCustomize.c M src/mainboard/lenovo/g505s/devicetree.cb 4 files changed, 16 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

8:20 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31450/4/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/4/src/mainboard/lenovo/g505s/OemCustom... PS4, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 19:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

8:21 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 212: if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) {

...

Luckily it turned out that we could set BottomIo to 0xD0 instead of 0xE0 at G505S "no-dGPU-version" […]

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 19:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Comment-In-Reply-To: mikeb mikeb mikebdp2@gmail.com Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

8:37 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 4:

...

Patch Set 3:

...
Patch Set 3:

GPIO59 can be used to detect presence of DGPU.

Sorry but G505 and G505S are different laptops, here is a correct datasheet for G505S - LA-A091P motherboard - http://www.s-manuals.com/pdf/motherboard/compal/compal_la-a091p_r1.0_schemat... . I don't know how to find a correct GPIO there... but it is not necessary anymore: see comment above, it turned out we could set BottomIO to 0xD0 for all G505S

Page 36 middle-right BRDID and it's 4-state analog input Vab on KB9012 embedded controller. Maybe something you can find from ACPI / EC commands.

OT: Have you poked on EC_TX and EC_RX signals? I *think* you would need some 10k or so pull-up, see comment on page 30.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 18 Feb 2019 19:37:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

21 Feb 21 Feb

4:12 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 4:

...

Patch Set 4:

...
Patch Set 3:

here is a correct datasheet for G505S - LA-A091P motherboard - http://www.s-manuals.com/pdf/motherboard/compal/compal_la-a091p_r1.0_schemat... . I don't know how to find a correct GPIO there... but it is not necessary anymore: see comment above, it turned out we could set BottomIO to 0xD0 for all G505S

Page 36 middle-right BRDID and it's 4-state analog input Vab on KB9012 embedded controller. Maybe something you can find from ACPI / EC commands.

OT: Have you poked on EC_TX and EC_RX signals? I *think* you would need some 10k or so pull-up, see comment on page 30.

Kyosti, thank you for your discoveries. Although recently we found out that we could just set it to BottomIO to 0xD0 for all G505S regardless of them having a discrete GPU (so no need to distinguish between them at the moment), maybe this information could be useful sometime in the future.

Could you please describe in more detail what exactly these EC_TX and EC_RX signals may be useful for? If for debug card - I already got it and tried inserting to this miniPCIe slot, and it is fully working: displaying the POST codes properly. More information at http://dangerousprototypes.com/docs/Compal_POST_diagnostic_card . This Compal datasheet is a bit older than motherboard and maybe these pull-ups have been implemented to the motherboard. Also, I hope that everything I am doing will be available to G505S people without requiring them to do any motherboard soldering, it could be risky for some.

Sorry, I just discovered that my patch above does not choose these configurations but I am using them in my local .config :

CONFIG_PCIEXP_L1_SUB_STATE=y #Enable PCIe Common Clock CONFIG_PCIEXP_ASPM=y #Enable PCIe ASPM CONFIG_PCIEXP_COMMON_CLOCK=y #Enable PCIe Clock Power Management CONFIG_PCIEXP_CLK_PM=y #Enable PCIe ASPM L1 SubState

Soon I will submit a new revision of this patch which will select these .config options for G505S by default.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 21 Feb 2019 15:12:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

22 Feb 22 Feb

8:57 a.m.

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#5).

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/OemCustomize.c M src/mainboard/lenovo/g505s/devicetree.cb 4 files changed, 20 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 5 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

8:57 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31450/5/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/5/src/mainboard/lenovo/g505s/OemCustom... PS5, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 5 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Fri, 22 Feb 2019 07:57:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:05 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/31450/6/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/6/src/mainboard/lenovo/g505s/OemCustom... PS6, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 6 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Fri, 22 Feb 2019 08:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

16 Mar 16 Mar

4:32 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31450/8/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/8/src/mainboard/lenovo/g505s/OemCustom... PS8, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 8 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Sat, 16 Mar 2019 15:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

7 Apr 7 Apr

7:23 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/31450/9/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/9/src/mainboard/lenovo/g505s/OemCustom... PS9, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 9 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Sun, 07 Apr 2019 17:23:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

19 May 19 May

9:10 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/31450/10/src/mainboard/lenovo/g505s/OemCusto... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/10/src/mainboard/lenovo/g505s/OemCusto... PS10, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 10 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 May 2019 07:10:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9 Jun 9 Jun

3:10 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/31450/11/src/mainboard/lenovo/g505s/OemCusto... File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/11/src/mainboard/lenovo/g505s/OemCusto... PS11, Line 212: /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ line over 80 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 11 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 09 Jun 2019 13:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5 Jan 5 Jan

7:06 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/31450/16//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/31450/16//COMMIT_MSG@7 PS16, Line 7: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop mb/lenovo/g505s: Add discrete VGA support

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 16 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jan 2020 18:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

8:18 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#17).

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

lenovo/g505s: Add discrete VGA support

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/OemCustomize.c M src/mainboard/lenovo/g505s/devicetree.cb 4 files changed, 20 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 17 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

8:48 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

Patch Set 17:

(1 comment)

Thank you! For an easier review I'm splitting this change to three smaller ones:

CB:38200 - src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols CB:38201 - lenovo/g505s: fix the VGA-related PCI resource allocation problems CB:38203 - lenovo/g505s: enable the discrete VGA adapter (depends on CB:38202)

https://review.coreboot.org/c/coreboot/+/31450/16//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/31450/16//COMMIT_MSG@7 PS16, Line 7: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

...

mb/lenovo/g505s: Add discrete VGA support

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 17 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jan 2020 19:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Mike Banon (Code Review)

6 Jan 6 Jan

9:56 a.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

Abandoned

Superseded by CB:38200, CB:38201 and CB:38203 for your convenience.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 17 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Mike Banon (Code Review)

19 Jan 19 Jan

1:59 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 17 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: restore

Mike Banon (Code Review)

2 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Hello Alexander Couzens, Patrick Rudolph, Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31450

to look at the new patch set (#18).

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

lenovo/g505s: Add discrete VGA support

Based on the original patches by Hans Jürgen Kitter eforname@freemail.hu.

Signed-off-by: Mike Banon mikebdp2@gmail.com Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 --- M src/device/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/OemCustomize.c M src/mainboard/lenovo/g505s/devicetree.cb 4 files changed, 20 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31450/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 18 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

2:31 p.m.

New subject: Change in coreboot[master]: lenovo/g505s: Add discrete VGA support

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add discrete VGA support ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/31450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88 Gerrit-Change-Number: 31450 Gerrit-PatchSet: 18 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1763

days inactive

2099

days old

coreboot-gerrit@coreboot.org

29 comments

7 participants

tags (0)

participants (7)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
build bot (Jenkins) (Code Review)
Kyösti Mälkki (Code Review)
Mike Banon (Code Review)
mikeb mikeb (Code Review)
Patrick Rudolph (Code Review)