Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46441 )
Change subject: util/ifdtool: Enable CPU read for ME region ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46441/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46441/7//COMMIT_MSG@8 PS7, Line 8: : We are implementing a mechanism in coreboot to update CSME firmware, : this requires coreboot to be able to read CSME region. Do you have a pointer to this? The current mechanism relies on querying the CSE to provide its version. What other information is being gathered by reading the CSE region directly?
https://review.coreboot.org/c/coreboot/+/46441/7//COMMIT_MSG@13 PS7, Line 13: This patch will enable read access to CSME region when locking. Should ifdtool honor the settings that are already present in the descriptor if it is not all ffs? Is this a problem that the region access bits are set to one value using FIT tool and then get overridden here?
-
Furquan Shaikh (Code Review)