Attention is currently required from: Vadim Bendebury, Martin L Roth, Patrick Georgi, Jakub Czapiga, Julius Werner, Yu-Ping Wu.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69710 )
Change subject: build: List all Kconfigs in CBFS `config` file, compress it
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69710/comment/dd4073b0_0f7ad17a
PS1, Line 334: \
Backslash here tells shell not to use any aliases. […]
It's not hurting anything and isn't a part of this change. If someone wants to remove it, that can be done in a follow-on patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5259ec6f932cdc5780b8843f46dd476da9d19728
Gerrit-Change-Number: 69710
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 21:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment