Change in coreboot[master]: [RFC,WIP] cpu/x86/lapic: Evaluate x2apic_mode just once - coreboot-gerrit

15 Oct 2021


      Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55198 )
Change subject: [RFC,WIP] cpu/x86/lapic: Evaluate x2apic_mode just once
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/55198/comment/15139bd3_941cd5b2 
PS12, Line 84: 	return x2apic_mode_enabled;
...
My objective is to evaluate is_x2apic_mode() as a constant in lapic.h accessor functions. […]
Sounds reasonable. My X2APIC_ONLY tests in CB:55262 show that it's doable, but there's some issues to sort out.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff4f5dc50999f977eaf9b32e7caebf098a3600fe
Gerrit-Change-Number: 55198
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ron Minnich rminnich@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 15 Oct 2021 14:23:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment