Change in coreboot[master]: util/lint: Provide some exemption to common parts of a vendor's MB
Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
util/lint: Provide some exemption to common parts of a vendor's MB
Adding common definitions for a vendor's mainboard(eg. CB:37705) requires creating dummy board_info.txt and Kconfig.name files due to lint checks. Update the lint scripts to provide exemption to common definitions for a vendor's mainboard.
BUG=None TEST=Ensure that no lint errors are observed when common definitions are added for a vendor's mainboard.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a --- M util/lint/lint-stable-005-board-status M util/lint/lint-stable-006-board-name 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37807/1
diff --git a/util/lint/lint-stable-005-board-status b/util/lint/lint-stable-005-board-status index 952a9b5..e8313f2 100755 --- a/util/lint/lint-stable-005-board-status +++ b/util/lint/lint-stable-005-board-status @@ -17,6 +17,10 @@
LC_ALL=C export LC_ALL for mobodir in $(git ls-files src/mainboard | sed -n 's,^(src/mainboard/[^/]*/[^/]*)/.*$,\1,p'|sort|uniq); do + if [[ ${mobodir} =~ ^src/mainboard/.*/common$ ]]; then + continue + fi + board_info="$mobodir/board_info.txt" if ! [ -f "$board_info" ]; then echo "No $board_info found" diff --git a/util/lint/lint-stable-006-board-name b/util/lint/lint-stable-006-board-name index b2418a1..cf3b0e2 100755 --- a/util/lint/lint-stable-006-board-name +++ b/util/lint/lint-stable-006-board-name @@ -29,6 +29,9 @@ done
for i in src/mainboard/*/*/; do + if [[ ${i} =~ ^src/mainboard/.*/common/$ ]]; then + continue + fi if [ -r $i/Kconfig ]; then if [ ! -r $i/Kconfig.name ]; then BOARD="$(grep -A2 MAINBOARD_PART_NUMBER $i/Kconfig | tail -1 | cut -f2 -d")"
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... File util/lint/lint-stable-005-board-status:
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... PS2, Line 20: if [[ ${mobodir} =~ ^src/mainboard/.*/common$ ]]; then : continue : fi I based https://review.coreboot.org/c/coreboot/+/37705/5 on top of this CL, the lint check fails for it. Does the path needs to be src/mainboard/[^/]*/common instead?
Hello Arthur Heymans, Aamir Bohra, Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37807
to look at the new patch set (#3).
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
util/lint: Provide some exemption to common parts of a vendor's MB
Adding common definitions for a vendor's mainboard(eg. CB:37705) requires creating dummy board_info.txt and Kconfig.name files due to lint checks. Update the lint scripts to provide exemption to common definitions for a vendor's mainboard.
BUG=None TEST=Ensure that no lint errors are observed when common definitions are added for a vendor's mainboard.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a --- M util/lint/lint-stable-005-board-status M util/lint/lint-stable-006-board-name 2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37807/3
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... File util/lint/lint-stable-005-board-status:
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... PS2, Line 20: if [[ ${mobodir} =~ ^src/mainboard/.*/common$ ]]; then : continue : fi
I based https://review.coreboot. […]
Done. The suggested regex is better than the original one. I tried running util/lint/lint lint-stable on my workstation and it completed successfully with and without your CL.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... File util/lint/lint-stable-005-board-status:
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b... PS2, Line 20: if [[ ${mobodir} =~ ^src/mainboard/.*/common$ ]]; then : continue : fi
Done. The suggested regex is better than the original one. […]
Lint check still seems to fail for mb/intel/common CLs, can I keep the Kconfig.name and board_info.txt for now? and remove once we have this CL merged?
Karthik Ramasubramanian has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB ......................................................................
Abandoned
-
Aamir Bohra (Code Review) -
Karthik Ramasubramanian (Code Review)