Change in coreboot[master]: util/ifdtool: Identify between ICH and PCH Revision

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Subrata Banik (Code Review)

26 Aug 2020 26 Aug '20

11:53 a.m.

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH family.

BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform.

...

ifdtool -d coreboot.rom

Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 --- M util/ifdtool/ifdtool.c 1 file changed, 11 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44816/1

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 1880900..b15b163 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -511,6 +511,13 @@ } }

+static int is_platform_with_pch(void) +{ + if (chipset >= CHIPSET_5_SERIES_IBEX_PEAK) + return 1; + + return 0; +} static void dump_fcba(const fcba_t *fcba) { printf("\nFound Component Section\n"); @@ -757,7 +764,10 @@ if (!fdb) exit(EXIT_FAILURE);

- printf("ICH Revision: %s\n", ich_chipset_names[chipset]); + if (is_platform_with_pch()) + printf("PCH Revision: %s\n", ich_chipset_names[chipset]); + else + printf("ICH Revision: %s\n", ich_chipset_names[chipset]); printf("FLMAP0: 0x%08x\n", fdb->flmap0); printf(" NR: %d\n", (fdb->flmap0 >> 24) & 7); printf(" FRBA: 0x%x\n", ((fdb->flmap0 >> 16) & 0xff) << 4);

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

26 Aug 26 Aug

9:23 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c@767 PS1, Line 767: if (is_platform_with_pch()) : printf("PCH Revision: %s\n", ich_chipset_names[chipset]); : else : printf("ICH Revision: %s\n", ich_chipset_names[chipset]); nit: something like printf("%s", is_platform_with_pch() ? "PCH" : "ICH"); printf(" Revision: %s\n", ich_chipset_names[chipset]);

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 26 Aug 2020 19:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

27 Aug 27 Aug

9:51 a.m.

Hello build bot (Jenkins), Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44816

to look at the new patch set (#2).

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH family.

BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform.

...

ifdtool -d coreboot.rom

Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 --- M util/ifdtool/ifdtool.c 1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44816/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

9:52 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:

...

nit: something like […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 27 Aug 2020 07:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:52 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/44816/2/util/ifdtool/ifdtool.c@769 PS2, Line 769: printf("%s", is_platform_with_pch() ? "PCH": "ICH"); spaces required around that ':' (ctx:VxW)

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 27 Aug 2020 07:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

9:54 a.m.

Hello build bot (Jenkins), Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44816

to look at the new patch set (#3).

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH family.

BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform.

...

ifdtool -d coreboot.rom

Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 --- M util/ifdtool/ifdtool.c 1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44816/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

9:55 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/44816/2/util/ifdtool/ifdtool.c@769 PS2, Line 769: printf("%s", is_platform_with_pch() ? "PCH": "ICH");

...

spaces required around that ':' (ctx:VxW)

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 27 Aug 2020 07:55:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:17 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44816/3//COMMIT_MSG@10 PS3, Line 10: family. nit: fits on previous line

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-Comment-Date: Thu, 27 Aug 2020 17:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

28 Aug 28 Aug

8:49 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44816/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44816/3//COMMIT_MSG@10 PS3, Line 10: family.

...

nit: fits on previous line

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-Comment-Date: Fri, 28 Aug 2020 06:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Subrata Banik (Code Review)

8:49 a.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44816

to look at the new patch set (#4).

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH family.

BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform.

...

ifdtool -d coreboot.rom

Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 --- M util/ifdtool/ifdtool.c 1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44816/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

31 Aug 31 Aug

10:42 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-Comment-Date: Mon, 31 Aug 2020 20:42:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Sep 2 Sep

9:17 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH family.

BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform.

...

ifdtool -d coreboot.rom

Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44816 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M util/ifdtool/ifdtool.c 1 file changed, 9 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 2388ebc..fa7817a 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -513,6 +513,13 @@ } }

- printf("ICH Revision: %s\n", ich_chipset_names[chipset]); + printf("%s", is_platform_with_pch() ? "PCH" : "ICH"); + printf(" Revision: %s\n", ich_chipset_names[chipset]); printf("FLMAP0: 0x%08x\n", fdb->flmap0); printf(" NR: %d\n", (fdb->flmap0 >> 24) & 7); printf(" FRBA: 0x%x\n", ((fdb->flmap0 >> 16) & 0xff) << 4);

-- To view, visit https://review.coreboot.org/c/coreboot/+/44816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Gerrit-Change-Number: 44816 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subi.banik@gmail.com Gerrit-MessageType: merged

1543

days inactive

1550

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Patrick Georgi (Code Review)
Subrata Banik (Code Review)
Tim Wawrzynczak (Code Review)