Matt Papageorge has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
mb/google/zork/baseboard: Remove unused reference
Remove references to clk_pm_support which is currently ignored by Picasso AGESA FSP.
BUG=b:161218965,b:162423378 TEST=Build test Trembyle and Dali, boot to ChromeOS 5 times each
Change-Id: Ic5d6abc56821863b68e45c11763f00d2b6410983 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com --- M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c 2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/44556/1
diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c index c6e63ad..4be866d 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c @@ -27,7 +27,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ2, - .clk_pm_support = true, }, { // WLAN @@ -42,7 +41,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c index 26a5d33..49d8ade 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c @@ -46,7 +46,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader @@ -78,7 +77,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ4, - .clk_pm_support = true, }, { // WLAN @@ -93,7 +91,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
Patch Set 1: Code-Review+2
Justin Frodsham has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
Patch Set 1: Code-Review+1
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
mb/google/zork/baseboard: Remove unused reference
Remove references to clk_pm_support which is currently ignored by Picasso AGESA FSP.
BUG=b:161218965,b:162423378 TEST=Build test Trembyle and Dali, boot to ChromeOS 5 times each
Change-Id: Ic5d6abc56821863b68e45c11763f00d2b6410983 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44556 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Justin Frodsham justin.frodsham@amd.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Justin Frodsham: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c index c6e63ad..4be866d 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c @@ -27,7 +27,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ2, - .clk_pm_support = true, }, { // WLAN @@ -42,7 +41,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c index 26a5d33..49d8ade 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c @@ -46,7 +46,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader @@ -78,7 +77,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ4, - .clk_pm_support = true, }, { // WLAN @@ -93,7 +91,6 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ0, - .clk_pm_support = true, }, { // SD Reader
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44556 )
Change subject: mb/google/zork/baseboard: Remove unused reference ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/15876 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15875 "QEMU x86 i440fx/piix4" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/15874 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15873 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/15872 "HP Z220 SFF Workstation" using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/15879 "HP Compaq 8200 Elite SFF PC" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/15878 "HP Compaq 8200 Elite SFF PC" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15877
Please note: This test is under development and might not be accurate at all!