Change in coreboot[master]: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset

[Subrata Banik (Code Review)]

Attention is currently required from: Subrata Banik, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Stefan Reinauer, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )

Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
......................................................................

Patch Set 6:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/54305/comment/691b6184_cd1d2aed 
PS6, Line 8:
> You have captured all the details in the commit message, but it still seems a little confusing. […]

Ack

File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/54305/comment/5a6c5f2c_e5cebcaa 
PS6, Line 207: guess_ifd_2_chipset
> I think this function should be named differently. It is not really guessing the chipset. […]

Ack

https://review.coreboot.org/c/coreboot/+/54305/comment/010044dd_29394245 
PS6, Line 246: chipset = guess_ifd_2_chipset(platform);
> Since this function is named `is_platform_ifd_2()`, I think it is not correct to have a side-effect  […]

Ack

https://review.coreboot.org/c/coreboot/+/54305/comment/0e7cdc5f_406f03a4 
PS6, Line 274: switch (read_freq) {
             : 	case SPI_FREQUENCY_20MHZ:
             : 		return IFD_VERSION_1;
             : 	case SPI_FREQUENCY_17MHZ:
             : 	case SPI_FREQUENCY_50MHZ_30MHZ:
             : 		return IFD_VERSION_2;
             : 	default:
             : 		fprintf(stderr, "Unknown descriptor version: %d\n",
             : 			read_freq);
             : 		exit(EXIT_FAILURE);
             : 	}
> Also, is this required at all? If we are enforcing that all IFDv2 platforms must provide -p argument […]

Ack