Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
mb/intel/coffeelake_rvp: Add cpu count for CFL S62
increase CPU max core count to 16 for coffeelake Refresh-S Platform.
TEST: boot to linux OS on CFL-S refresh platform and verified the output of cat /proc/cpuinfo shows no of processor=16.
Signed-off-by: Lean Sheng Tan lean.sheng.tan@intel.com Change-Id: I579ff6ae8227844741406c503d3994408ec2b617 --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/34156/1
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index e75fe2a..13e55b3 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -53,7 +53,8 @@
config MAX_CPUS int - default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 + default 12 if BOARD_INTEL_COFFEELAKE_RVP11 + default 16 if BOARD_INTEL_COFFEELAKE_RVP8 default 8
config UART_FOR_CONSOLE
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34156/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34156/1//COMMIT_MSG@9 PS1, Line 9: i Increases
Hello Subrata Banik, Aamir Bohra, Maulik V Vaghela, Boon Tiong Teo, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34156
to look at the new patch set (#2).
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
mb/intel/coffeelake_rvp: Add cpu count for CFL S62
Increases CPU max core count to 16 for coffeelake Refresh-S Platform.
TEST: boot to linux OS on CFL-S refresh Intel RVP and verified the output of cat /proc/cpuinfo shows no of processor=16.
Signed-off-by: Lean Sheng Tan lean.sheng.tan@intel.com Change-Id: I579ff6ae8227844741406c503d3994408ec2b617 --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/34156/2
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34156/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34156/1//COMMIT_MSG@9 PS1, Line 9: i
Increases
Done
Boon Tiong Teo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
Patch Set 2: Code-Review+1
Look good
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34156 )
Change subject: mb/intel/coffeelake_rvp: Add cpu count for CFL S62 ......................................................................
mb/intel/coffeelake_rvp: Add cpu count for CFL S62
Increases CPU max core count to 16 for coffeelake Refresh-S Platform.
TEST: boot to linux OS on CFL-S refresh Intel RVP and verified the output of cat /proc/cpuinfo shows no of processor=16.
Signed-off-by: Lean Sheng Tan lean.sheng.tan@intel.com Change-Id: I579ff6ae8227844741406c503d3994408ec2b617 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34156 Reviewed-by: Boon Tiong Teo boon.tiong.teo@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Subrata Banik: Looks good to me, approved Boon Tiong Teo: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index e75fe2a..13e55b3 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -53,7 +53,8 @@
config MAX_CPUS int - default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 + default 12 if BOARD_INTEL_COFFEELAKE_RVP11 + default 16 if BOARD_INTEL_COFFEELAKE_RVP8 default 8
config UART_FOR_CONSOLE
-
Boon Tiong Teo (Code Review) -
Furquan Shaikh (Code Review)
-
Lean Sheng Tan (Code Review)
-
Martin Roth (Code Review)
-
Subrata Banik (Code Review)