Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
mb/google/volteer: add ec device entry to devicetree
BUG=b:154279851 TEST=none
Change-Id: Ibb56d97d5180ab199c52119135f7eff265908667 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40494/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index ab911d2..593fbeb 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -362,8 +362,11 @@ device spi 0 on end end # FPMCU end # GSPI1 0xA0AB - - device pci 1f.0 on end # eSPI 0xA080 - A09F + device pci 1f.0 on + chip ec/google/chromeec + device pnp 0c09.0 on end + end + end # eSPI 0xA080 - A09F device pci 1f.1 off end # P2SB 0xA0A0 device pci 1f.2 on end # PMC 0xA0A1 device pci 1f.3 on
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
Patch Set 2: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
Patch Set 2: Code-Review-2
Putting this CL into a holding pattern until https://review.coreboot.org/c/coreboot/+/40494 is fixed.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
Patch Set 2:
Sorry about the copy/paste error in last comment.
Putting this CL into a holding pattern until https://b.corp.google.com/issues/154340911 is fixed.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
Patch Set 5: -Code-Review
The problem is fixed with https://review.coreboot.org/c/coreboot/+/40354, taking this CL out of holding pattern, it's ready to merge.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40494 )
Change subject: mb/google/volteer: add ec device entry to devicetree ......................................................................
mb/google/volteer: add ec device entry to devicetree
BUG=b:154279851 TEST=none
Change-Id: Ibb56d97d5180ab199c52119135f7eff265908667 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40494 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 2937bbd..8a6bcf3 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -348,8 +348,11 @@ device spi 0 on end end # FPMCU end # GSPI1 0xA0AB - - device pci 1f.0 on end # eSPI 0xA080 - A09F + device pci 1f.0 on + chip ec/google/chromeec + device pnp 0c09.0 on end + end + end # eSPI 0xA080 - A09F device pci 1f.1 off end # P2SB 0xA0A0 device pci 1f.2 on end # PMC 0xA0A1 device pci 1f.3 on
-
Furquan Shaikh (Code Review) -
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)