Change in ...coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33464

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

mainboard/facebook/fbg1701: Add measured boot support

The vendorcode for measured boot is uploaded, but not used.
Add support to the mainboard for measured boot.

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 rev 0-2

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
M src/mainboard/facebook/fbg1701/Makefile.inc
M src/mainboard/facebook/fbg1701/romstage.c
2 files changed, 52 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/1

diff --git a/src/mainboard/facebook/fbg1701/Makefile.inc b/src/mainboard/facebook/fbg1701/Makefile.inc
index 07309c5..82cde0f 100644
--- a/src/mainboard/facebook/fbg1701/Makefile.inc
+++ b/src/mainboard/facebook/fbg1701/Makefile.inc
@@ -24,6 +24,8 @@
 ramstage-y += ramstage.c
 ramstage-y += w25q64.c

+romstage-$(CONFIG_VENDORCODE_ELTAN_MBOOT) += board_mboot.c
+
 cbfs-files-$(CONFIG_FSP1_1_DISPLAY_LOGO) += logo.bmp
 logo.bmp-file := $(call strip_quotes,$(CONFIG_FSP1_1_LOGO_FILE_NAME))
 logo.bmp-type := raw
diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c
index e2e37d6..6764b3c 100644
--- a/src/mainboard/facebook/fbg1701/romstage.c
+++ b/src/mainboard/facebook/fbg1701/romstage.c
@@ -15,10 +15,14 @@
  * GNU General Public License for more details.
  */

+#include <build.h>
 #include <cbfs.h>
 #include <console/console.h>
 #include <chip.h>
 #include <device/pci_ops.h>
+#if CONFIG(VENDORCODE_ELTAN_MBOOT)
+#include <mboot.h>
+#endif
 #include <soc/lpc.h>
 #include <soc/pci_devs.h>
 #include <soc/romstage.h>
@@ -49,3 +53,49 @@
    /* Disable the Braswell UART hardware for COM1. */
    pci_write_config32(PCI_DEV(0, LPC_DEV, 0), UART_CONT, 0);
 }
+
+#if CONFIG(VENDORCODE_ELTAN_MBOOT)
+/**
+ * mb_crtm
+ *
+ * Measures the crtm version. This consists of a string than can be defined
+ * using make menuconfig and automatically generated version information.
+ *
+ * @param[in]  activePcr	bitmap of the support
+ *
+ * @retval TPM_SUCCESS		Operation completed successfully.
+ * @retval TPM_E_IOERROR	Unexpected device behavior.
+ */
+
+static const uint8_t crtm_version[] =
+	CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING
+	COREBOOT_VERSION COREBOOT_EXTRA_VERSION " " COREBOOT_BUILD;
+
+int mb_crtm(EFI_TCG2_EVENT_ALGORITHM_BITMAP activePcr)
+{
+	int status = TPM_E_IOERROR;
+	TCG_PCR_EVENT2_HDR tcgEventHdr;
+
+	if (CONFIG(VENDORCODE_ELTAN_MBOOT)) {
+		/* Use FirmwareVersion string to represent CRTM version. */
+		printk(BIOS_DEBUG, "%s: Measure CRTM Version\n", __func__);
+		memset(&tcgEventHdr, 0, sizeof(tcgEventHdr));
+		tcgEventHdr.pcrIndex  = MBOOT_PCR_INDEX_0;
+		tcgEventHdr.eventType = EV_S_CRTM_VERSION;
+		tcgEventHdr.eventSize = sizeof(crtm_version);
+		printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__,
+			tcgEventHdr.eventSize);
+
+		status = mboot_hash_extend_log(activePcr, 0,
+				(uint8_t *)crtm_version,
+				tcgEventHdr.eventSize, &tcgEventHdr,
+				(uint8_t *)crtm_version, 0);
+
+		if (status)
+			printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n",
+				status);
+	}
+
+	return status;
+}
+#endif

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33464

to look at the new patch set (#3).

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

mainboard/facebook/fbg1701: Add measured boot support

The vendorcode for measured boot is uploaded, but not used.
Add support to the mainboard for measured boot.

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 rev 0-2

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
M src/mainboard/facebook/fbg1701/Makefile.inc
A src/mainboard/facebook/fbg1701/board_mboot.c
M src/mainboard/facebook/fbg1701/romstage.c
3 files changed, 85 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/3

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 33: uint32_t
Why not just `unsigned int`?

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34: 
Also the calculation is not mainboard specific, so could be moved to common code, couldn’t it?

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 33: uint32_t
> Why not just `unsigned int`?

Done

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34:
> Also the calculation is not mainboard specific, so could be moved to common code, couldn’t it?

The log list and counter are mainboard specific imo.
If for some reason not all items should be measured, this needs to modified in mainboard.

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33464

to look at the new patch set (#6).

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

mainboard/facebook/fbg1701: Add measured boot support

The vendorcode for measured boot is uploaded, but not used.
Add support to the mainboard for measured boot.

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 rev 0-2

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
M src/mainboard/facebook/fbg1701/Makefile.inc
A src/mainboard/facebook/fbg1701/board_mboot.c
M src/mainboard/facebook/fbg1701/romstage.c
3 files changed, 85 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/6

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34:
> The log list and counter are mainboard specific imo. […]

Done

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34:
> Done

Sorry for the misunderstanding. I mean, where is `mb_log_list_count` used? It should probably declared and used, where `mb_log_lis` is actually passed to.

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34:
> Sorry for the misunderstanding. […]

So the variable should be removed from mainboard code, and directly be used or calculated in https://review.coreboot.org/c/coreboot/+/30833/8/src/vendorcode/eltan/securi...

Change in coreboot[master]: mainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 7:

(1 comment)

Upload new patchset

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/board_mboot.c:

https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... 
PS5, Line 34:
> So the variable should be removed from mainboard code, and directly be used or calculated in https:/ […]

Done

Change in coreboot[master]: ainboard/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33464

to look at the new patch set (#8).

Change subject: ainboard/facebook/fbg1701: Add measured boot support
......................................................................

ainboard/facebook/fbg1701: Add measured boot support

No support is available in mainboard.
Add support to mainboard:
- Add mb_log_list[]
- Add routine mb_crtm()

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 rev 0-2

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
A src/mainboard/facebook/fbg1701/board_mboot.h
M src/mainboard/facebook/fbg1701/romstage.c
2 files changed, 81 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/8

Change in coreboot[master]: ainboard/facebook/fbg1701: Add measured boot support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: ainboard/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33464/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33464/8//COMMIT_MSG@7 
PS8, Line 7: ainboard
*m*ainboard, but I’d prefer the shorter *mb*.

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33464

to look at the new patch set (#9).

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

mb/facebook/fbg1701: Add measured boot support

No support is available in mainboard.
Add support to mainboard:
- Add mb_log_list[]
- Add routine mb_crtm()

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 rev 0-2

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
A src/mainboard/facebook/fbg1701/board_mboot.h
M src/mainboard/facebook/fbg1701/romstage.c
2 files changed, 81 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/9

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33464/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33464/8//COMMIT_MSG@7 
PS8, Line 7: ainboard
> *m*ainboard, but I’d prefer the shorter *mb*.

Done

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
File src/mainboard/facebook/fbg1701/romstage.c:

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
PS11, Line 79: 	if (CONFIG(VENDORCODE_ELTAN_MBOOT)
Is that still necessary because of line 57?

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
PS11, Line 94: 		if (status)
             : 			printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n",
             : 				status);
Latest coding style will require bracket under if even single line.

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Hello Patrick Rudolph, David Hendricks, Lance Zhao, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33464

to look at the new patch set (#12).

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

mb/facebook/fbg1701: Add measured boot support

No support is available in mainboard.
Add support to mainboard:
- Add mb_log_list[]
- Add routine mb_crtm()

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
---
A src/mainboard/facebook/fbg1701/board_mboot.h
M src/mainboard/facebook/fbg1701/romstage.c
2 files changed, 78 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33464/12

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
File src/mainboard/facebook/fbg1701/romstage.c:

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
PS11, Line 79: 	if (CONFIG(VENDORCODE_ELTAN_MBOOT)
> Is that still necessary because of line 57?

Removed

https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg... 
PS11, Line 94: 		if (status)
             : 			printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n",
             : 				status);
> Latest coding style will require bracket under if even single line.

Update to meet coding style

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

Patch Set 13: Code-Review+2

Change in coreboot[master]: mb/facebook/fbg1701: Add measured boot support

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33464 )

Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................

mb/facebook/fbg1701: Add measured boot support

No support is available in mainboard.
Add support to mainboard:
- Add mb_log_list[]
- Add routine mb_crtm()

BUG=N/A
TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Signed-off-by: Frans Hendriks 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33464
Tested-by: build bot (Jenkins) 
Reviewed-by: Lance Zhao 
---
A src/mainboard/facebook/fbg1701/board_mboot.h
M src/mainboard/facebook/fbg1701/romstage.c
2 files changed, 78 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lance Zhao: Looks good to me, approved

diff --git a/src/mainboard/facebook/fbg1701/board_mboot.h b/src/mainboard/facebook/fbg1701/board_mboot.h
new file mode 100644
index 0000000..5a23630
--- /dev/null
+++ b/src/mainboard/facebook/fbg1701/board_mboot.h
@@ -0,0 +1,31 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018-2019 Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <mboot.h>
+
+const mboot_measure_item_t mb_log_list[] = {
+	{ "config", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_0, EV_NO_ACTION, NULL },
+	{ "revision", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_0, EV_NO_ACTION, NULL },
+	{ "cmos_layout.bin", CBFS_COMPONENT_CMOS_LAYOUT, MBOOT_PCR_INDEX_0,
+		EV_NO_ACTION, NULL },
+#if CONFIG(VENDORCODE_ELTAN_VBOOT)
+	{ "oemmanifest.bin", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_7, EV_NO_ACTION,
+		NULL },
+#if CONFIG(VENDORCODE_ELTAN_VBOOT_SIGNED_MANIFEST)
+	{ "vboot_public_key.bin", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_6,
+		EV_NO_ACTION, NULL },
+#endif
+#endif
+};
diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c
index e2e37d6..d6b475c 100644
--- a/src/mainboard/facebook/fbg1701/romstage.c
+++ b/src/mainboard/facebook/fbg1701/romstage.c
@@ -15,10 +15,14 @@
  * GNU General Public License for more details.
  */

+#include <build.h>
 #include <cbfs.h>
 #include <console/console.h>
 #include <chip.h>
 #include <device/pci_ops.h>
+#if CONFIG(VENDORCODE_ELTAN_MBOOT)
+#include <mboot.h>
+#endif
 #include <soc/lpc.h>
 #include <soc/pci_devs.h>
 #include <soc/romstage.h>
@@ -49,3 +53,46 @@
    /* Disable the Braswell UART hardware for COM1. */
    pci_write_config32(PCI_DEV(0, LPC_DEV, 0), UART_CONT, 0);
 }
+
+#if CONFIG(VENDORCODE_ELTAN_MBOOT)
+/**
+ * mb_crtm
+ *
+ * Measures the crtm version. This consists of a string than can be defined
+ * using make menuconfig and automatically generated version information.
+ *
+ * @param[in]  activePcr	bitmap of the support
+ *
+ * @retval TPM_SUCCESS		Operation completed successfully.
+ * @retval TPM_E_IOERROR	Unexpected device behavior.
+ */
+
+static const uint8_t crtm_version[] =
+	CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING
+	COREBOOT_VERSION COREBOOT_EXTRA_VERSION " " COREBOOT_BUILD;
+
+int mb_crtm(EFI_TCG2_EVENT_ALGORITHM_BITMAP activePcr)
+{
+	int status = TPM_E_IOERROR;
+	TCG_PCR_EVENT2_HDR tcgEventHdr;
+
+	/* Use FirmwareVersion string to represent CRTM version. */
+	printk(BIOS_DEBUG, "%s: Measure CRTM Version\n", __func__);
+	memset(&tcgEventHdr, 0, sizeof(tcgEventHdr));
+	tcgEventHdr.pcrIndex  = MBOOT_PCR_INDEX_0;
+	tcgEventHdr.eventType = EV_S_CRTM_VERSION;
+	tcgEventHdr.eventSize = sizeof(crtm_version);
+	printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__,
+	       tcgEventHdr.eventSize);
+
+	status = mboot_hash_extend_log(activePcr, 0, (uint8_t *)crtm_version,
+				       tcgEventHdr.eventSize, &tcgEventHdr,
+				       (uint8_t *)crtm_version, 0);
+	if (status) {
+		printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n",
+		       status);
+	}
+
+	return status;
+}
+#endif