Attention is currently required from: Tarun Tuli, Kyle Lin, Frank Chu.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69784 )
Change subject: mb/google/brya/var/marasov: Update SPD ID assignment
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/marasov/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/69784/comment/6a0b5694_35d67c9d
PS2, Line 7: 0 (0000)
: H9JCNNNBK3MLYR-N6E 1 (0001)
: MT62F1G32D4DR-031 WT:B 2 (0010)
: H9JCNNNCP3MLYR-N6E 3
I will give this CL a +2 as-is, but JFYI, it would be more efficient to define the dram id strap values as follows:
DRAM Part Name ID to assign
MT62F512M32D2DR-031 WT:B 0 (0000)
H9JCNNNBK3MLYR-N6E 0 (0001)
MT62F1G32D4DR-031 WT:B 1 (0010)
H9JCNNNCP3MLYR-N6E 1 (0011)
I thought the tool assigned it this way automatically to save more open slots of DRAM_ID values for future memory upgrades and to include fewer SPD files in the image.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a62cf355508debce387c48d9d089e73763b2bf0
Gerrit-Change-Number: 69784
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kyle Lin
kylelinck@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 21:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment