[S] Change in coreboot[master]: acpi: Add function to print debug string directly from formatted string - coreboot-gerrit

21 Feb 2023


      Attention is currently required from: Bora Guvendik, Lance Zhao, Hannah Williams, Jakub Czapiga, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 )
Change subject: acpi: Add function to print debug string directly from formatted string
......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/73113/comment/6e8dec18_c4020f19 
PS2, Line 508: acpigen_write_debug
...
nit: how about: `acpigen_write_debug_sprintf()` or some other name which would indicate this functio […]
sounds good to me.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
Gerrit-Change-Number: 73113
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga jacz@semihalf.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 18:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga jacz@semihalf.com
Gerrit-MessageType: comment