Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, hualin wei.
Dinesh Gehlot has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86510?usp=email )
Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86510/comment/744229b0_33f3b6ad?usp... :
PS3, Line 15: Build coreboot, flash, boot to
: and log into kernel, execute "wp enable" in console,
: execute "crossystem" at kernel prompt and verify that "wpsw_cur"
: shows as being "1", Execute "wp disable" in console, execute
: "crossystem" at kernel prompt and verify "wpsw_cur" is 0.
wp status update verified by toggling it on and off.
File src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/86510/comment/f6f113ab_31c94963?usp... :
PS3, Line 14: #if CONFIG(BOARD_GOOGLE_PUJJONIRU)
: #define GPIO_PCH_WP GPP_E17
: #else
: #define GPIO_PCH_WP GPP_E12
: #endif
Instead of adding a condition to the baseboard, we can update the WP GPIO at a specific variant level. In this case, we can update `pujjoniru/include/variant/gpio.h` as below
```
#undef GPIO_PCH_WP
#define GPIO_PCH_WP GPP_E17
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86510?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee76fa8b357aa472699f17789b2c718028f812a3
Gerrit-Change-Number: 86510
Gerrit-PatchSet: 3
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cindy Lu
luyi8@huaqin.corp-partner.google.com
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Feb 2025 20:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No