Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/autoport: Make printing of SPDX headers generic ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File util/autoport/ec_none.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/9d64ed8d_02048f71?usp... : PS4, Line 17: : : si := Create(ctx, "acpi/superio.asl") : defer si.Close() : : ec := Create(ctx, "acpi/ec.asl") : defer ec.Close() I think we require empty files to be licensed under CC-PDDC or something?
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/d4c07adf_ec8ccef3?usp... : PS4, Line 237: func Add_SPDX(f *os.File, filetype Filetype, license License) {
`Possible repeated word: 'filetype'`
*smacks checkpatch with a broom*