Attention is currently required from: Timofey Komarov, Felix Singer, Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52693 )
Change subject: soc/intel/skylake: Add microcodes for Coffee Lake CPUs ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52693/comment/79a6bd0c_3e63bada PS7, Line 9: nit: there shouldn't be any spaces at the start of the lines
https://review.coreboot.org/c/coreboot/+/52693/comment/d6961c66_b28259db PS7, Line 13: Mentioned PCHs are meant to be paired with Coffee Lake CPUs, so : proper microcodes are added. This sentence should be in imperative tense:
Mentioned PCHs are meant to be paired with Coffee Lake CPUs, so add the corresponding microcodes.
Also, I wouldn't put this sentence on a separate paragraph.
-
Angel Pons (Code Review)