Attention is currently required from: Hung-Te Lin, Julius Werner, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 )
Change subject: lib/coreboot_table: Simplify API to set up lb_serial
......................................................................
Patch Set 1:
(1 comment)
File src/lib/coreboot_table.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161156):
https://review.coreboot.org/c/coreboot/+/68768/comment/848cf52b_3656e26c
PS1, Line 114: lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, header);;
Statements terminations use 1 semicolon
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68768
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d
Gerrit-Change-Number: 68768
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 12:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment