Change in coreboot[master]: src/intel: Add LOCKDIS to mark SPI as writable in SKL

[Star Labs (Code Review)]

Attention is currently required from: Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52796 )

Change subject: src/intel: Add LOCKDIS to mark SPI as writable in SKL
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4:
> Please go more I to detail here. […]

To clarify, it's just the BIOS Control register - the SPI is indeed writable.

coreboot seems to set the BC to 8b for every platform apart from SKL - which is right, locked but writable.

On SKL, it sets it to 80, locked and not writable.

fwupd was just how I found the issue, but other tools like chipsec also check the same register.