Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Ravindra, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 )
Change subject: soc/intel/alderlake: Trigger cse_fw_sync before DRAM Init ......................................................................
Patch Set 12:
(3 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/55364/comment/2005328c_53df93c6 PS12, Line 145: cse_fw_sync() must be called after DRAM initialization as : * HMRFPO_ENABLE HECI command (which is used by cse_fw_sync()) : * is expected to be executed after DRAM initialization.
what happen to this recommendation. […]
As part of cse_fw_sync(), coreboot sends few commands like GET BOOT PARTITION INFO, SET BOOT PARTITION INFO, HMRFPO ENABLE and GLOBAL RESET commands to CSE in different scenarios. Earlier CSE FW used to support HMRFPO ENABLE after only DRAM Initialization. But, recent CSE FW Version can support HMRFPO ENABLE even before DRAM initialization, hence I am moving up the cse_fw_sync() call before DRAM Init.
The earlier advisory is not applicable so I removed it.
https://review.coreboot.org/c/coreboot/+/55364/comment/a0c453e6_e9713ed1 PS12, Line 140:
can we add a timestamp around this to know how much time we are really spending for this command if […]
We can add, I will push the updated patch.
https://review.coreboot.org/c/coreboot/+/55364/comment/91f325ee_c0260461 PS12, Line 142: cse_fw_sync
can you move this call immediately after heci_init() ?
Since the cse_fw_sync() is not be run during S3 resume , it has to be after line#130. Since code@line#139 was added recently, so I will move the call after #line 130.