[S] Change in coreboot[master]: soc/intel/meteorlake: Rename method is_eom to is_manufacturing_mode - coreboot-gerrit

24 Nov 2022


      Attention is currently required from: Tarun Tuli, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69698 )
Change subject: soc/intel/meteorlake: Rename method is_eom to is_manufacturing_mode
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/meteorlake/me.c:
https://review.coreboot.org/c/coreboot/+/69698/comment/8f5d5a1f_a605616a 
PS1, Line 79: is_manuf_mode
...
What is the point of not writing `is_manufacturing_mode()`? It’d be great, if you improved that in a […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d2de3365126ba618c987c412c4e9784012f9e0b
Gerrit-Change-Number: 69698
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 12:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Kapil Porwal kapilporwal@google.com
Comment-In-Reply-To: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-MessageType: comment