Attention is currently required from: Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 )
Change subject: security/intel/cbnt: Add logging
......................................................................
Patch Set 10:
(3 comments)
File src/security/intel/cbnt/logging.c:
https://review.coreboot.org/c/coreboot/+/54093/comment/a6ffa6ed_30d54ab0
PS7, Line 106: const char *bios_acm = "BIOS ACM Error", *sinit_acm = "SINIT ACM Error",
: *btg = "Boot Guard Error", *reserved = "Reserved";
:
: switch (type) {
: case 0:
: return bios_acm;
: case 1:
: return sinit_acm;
: case 3:
: return btg;
: default:
: return reserved;
: }
Er, what I meant in PS6 is: […]
Done
https://review.coreboot.org/c/coreboot/+/54093/comment/4c70e066_434968a3
PS7, Line 123: }
Very minor nit: the opening brace has a space afterwards, but the closing brace doesn't have a space […]
Done
https://review.coreboot.org/c/coreboot/+/54093/comment/851165fe_f5decdb8
PS7, Line 159: ERRORCODE
I'd also drop redundant `ERRORCODE` mentions from here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635
Gerrit-Change-Number: 54093
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Jun 2021 05:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment