Change in coreboot[master]: soc/intel/tigerlake: add support to read spd data from SMBUS
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39401 )
Change subject: soc/intel/tigerlake: add support to read spd data from SMBUS ......................................................................
Patch Set 3:
(4 comments)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39401/1/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39401/1/src/soc/intel/tigerlake/mem... PS1, Line 50: memset(&mem_cfg->SpdAddressTable, 0, sizeof(mem_cfg->SpdAddressTable));
two instances not needed, we can keep it as original place, the sbmus would re-initialize it anyway.
I will do change so get_spd_data() will no change.
https://review.coreboot.org/c/coreboot/+/39401/1/src/soc/intel/tigerlake/mem... PS1, Line 120: spd_data_ptr
this is not getting initialized now, meminit_channels would set the invalid values for MemorySpdPtrX […]
I will do change so get_spd_data() will no change.
https://review.coreboot.org/c/coreboot/+/39401/1/src/soc/intel/tigerlake/mem... PS1, Line 122: get_spd_data
We can handle the SMBUS case here instead of changing the func to accommodate SMBUS, get_spd_data, s […]
go it
https://review.coreboot.org/c/coreboot/+/39401/3/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39401/3/src/soc/intel/tigerlake/mem... PS3, Line 122: get_spd_data
can u do something like this ? in that way u don't need to change assumptions of get_spd_data() […]
got your point will change this.
-
Ronak Kanabar (Code Review)