Attention is currently required from: Andy Ebrahiem, Angel Pons, Jincheng Li, Jérémy Compostella, Maximilian Brune, Naresh Solanki, Patrick Rudolph, Shuo Liu.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85638?usp=email )
Change subject: arch/x86/cpu: Add helper function to compute cache
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/85638/comment/6d6b0168_30e471ab?usp... :
PS7, Line 215: bool __weak soc_fill_cpu_cache_info(uint8_t level, struct cpu_cache_info *info)
hmm, i wonder if it would be better to have a kconfig option to replace the common implementation by a soc-specific one instead of having a weak function that gets overridden.
in soc/amd we tried to minimize the usage of weak functions, since in the kconfig symbol case, mismatches result in linker errors instead of unexpected behavior.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85638?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60707de4c8242a8fbda8cb5b791a1db762d94449
Gerrit-Change-Number: 85638
Gerrit-PatchSet: 7
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: NyeonWoo Kim
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Ebrahiem
ahmet.ebrahiem@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Andy Ebrahiem
ahmet.ebrahiem@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 19:55:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes