Attention is currently required from: Hung-Te Lin, Paul Menzel, Trevor Wu, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: support max98390 audio amp ......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63083/comment/9ad3a6e6_f0205c68 PS6, Line 10: output
Some words can be put in the previous line.
Done
File src/mainboard/google/cherry/chromeos.c:
https://review.coreboot.org/c/coreboot/+/63083/comment/79df8b6a_5f833ab2 PS4, Line 26:
is this ok? […]
or choice prompt "Speaker AMP for Cherry" default CHERRY_USE_RT1019 if BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO default CHERRY_USE_MAX98390 if BOARD_GOOGLE_DOJO
config CHERRY_USE_RT1011 bool "RT1011" config CHERRY_USE_RT1019 bool "RT1019" config CHERRY_USE_MAX98390 bool "MAX98390"
endchoice
File src/mainboard/google/cherry/chromeos.c:
https://review.coreboot.org/c/coreboot/+/63083/comment/e544d975_80c8d7df PS6, Line 26: _Static_assert(CONFIG(CHERRY_USE_RT1019) + CONFIG(CHERRY_USE_RT1011) +
One blank line above.
removed
-
Rex-BC Chen (Code Review)