Change in coreboot[master]: mb/google/dedede: Update Boten setting for USI PEN detection.

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Rasheed Hsueh (Code Review)

15 Dec 2020 15 Dec '20

4:56 p.m.

Rasheed Hsueh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

mb/google/dedede: Update Boten setting for USI PEN detection.

Update devicetree and gpio driving of boten that enable stylus

BUG=b:160752604 BRANCH=dedede TEST=Build and check behavior is expected.

Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 --- M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48641/1

diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c index 0c81872..09c7a5d 100644 --- a/src/mainboard/google/dedede/variants/boten/gpio.c +++ b/src/mainboard/google/dedede/variants/boten/gpio.c @@ -11,7 +11,7 @@ PAD_CFG_GPO(GPP_A10, 0, PLTRST),

Attachments:

attachment.htm (text/html — 4.4 KB)

Show replies by date

Furquan Shaikh (Code Review)

16 Dec 16 Dec

4:18 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG@9 PS1, Line 9: Update devicetree and gpio driving of boten that enable stylus Can you please add the following details as well:

PEN detect signal is not dual-routed on Boten. Since the gpio_keys kernel driver expects the pad to be owned by GPIO controller (i.e. configured for GPIO IRQ), it cannot be configured for ACPI (i.e. SCI). Thus, this change updates the GPIO configuration for GPP_C12 to PAD_CFG_GPI_GPIO_DRIVER and device tree entry for PENH device to use WAKEUP_ROUTE_GPIO_IRQ. Additionally, the signal is marked as active low in the device tree entry to indicate to the kernel driver that the signal is inverted.

Not dual routing the signal results in wake source not being added to eventlog when pen removal results in wake from S0ix.

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119: Can you please replace the spaces with tabs like it is for other lines in this file?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 1 Gerrit-Owner: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Tue, 15 Dec 2020 19:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rasheed Hsueh (Code Review)

10:16 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48641

to look at the new patch set (#2).

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

mb/google/dedede: Update Boten setting for USI PEN detection.

Update devicetree and gpio driving of boten that enable stylus

Not dual routing the signal results in wake source not being added to eventlog when pen removal results in wake from S0ix.

BUG=b:160752604 BRANCH=dedede TEST=Build and check behavior is expected.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48641/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 2 Gerrit-Owner: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-MessageType: newpatchset

rasheed.hsueh (Code Review)

10:18 a.m.

rasheed.hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG@9 PS1, Line 9: Update devicetree and gpio driving of boten that enable stylus

...

Can you please add the following details as well: […]

Done

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119:

...

Can you please replace the spaces with tabs like it is for other lines in this file?

Thanks for remind. Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 2 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 01:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:18 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 2: Code-Review+2

Just a nit about replacing spaces with tabs in overridetree. Rest looks good.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 2 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 01:18:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:19 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119:

...

Thanks for remind. Done.

This is still missing in latest patchset.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 2 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 01:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

rasheed.hsueh (Code Review)

10:26 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48641

to look at the new patch set (#3).

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

mb/google/dedede: Update Boten setting for USI PEN detection.

Update devicetree and gpio driving of boten that enable stylus

Not dual routing the signal results in wake source not being added to eventlog when pen removal results in wake from S0ix.

BUG=b:160752604 BRANCH=dedede TEST=Build and check behavior is expected.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48641/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 3 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-MessageType: newpatchset

rasheed.hsueh (Code Review)

10:29 a.m.

rasheed.hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Set Ready For Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 4 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 01:29:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

rasheed.hsueh (Code Review)

10:31 a.m.

rasheed.hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119:

...

This is still missing in latest patchset.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 4 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 01:31:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:28 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119:

...

Done

Thank you, Rasheed!

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 4 Gerrit-Owner: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 06:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

17 Dec 17 Dec

10:08 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 4 Gerrit-Owner: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-Comment-Date: Thu, 17 Dec 2020 01:08:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

21 Dec 21 Dec

11:37 a.m.

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48641 )

Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................

mb/google/dedede: Update Boten setting for USI PEN detection.

Update devicetree and gpio driving of boten that enable stylus

Not dual routing the signal results in wake source not being added to eventlog when pen removal results in wake from S0ix.

BUG=b:160752604 BRANCH=dedede TEST=Build and check behavior is expected.

Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48641 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 12 insertions(+), 13 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved

/* C12 : AP_PEN_DET_ODL */ - PAD_CFG_GPI_SCI(GPP_C12, UP_20K, DEEP, EDGE_SINGLE, NONE), + PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, UP_20K, DEEP), /* C18 : AP_I2C_EMR_SDA */ PAD_NC(GPP_C18, NONE), /* C19 : AP_I2C_EMR_SCL */ diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index d2540e3..ab8fcdb 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -116,18 +116,17 @@ end end # I2C 0 device pci 15.2 on - chip drivers/generic/gpio_keys - register "name" = ""PENH"" - register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_C12)" - register "key.wake_gpe" = "GPE0_DW1_12" - register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" - register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" - register "key.dev_name" = ""EJCT"" - register "key.linux_code" = "SW_PEN_INSERTED" - register "key.linux_input_type" = "EV_SW" - register "key.label" = ""pen_eject"" - device generic 0 on end - end + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_C12)" + register "key.wakeup_route" = "WAKEUP_ROUTE_GPIO_IRQ" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen""

-- To view, visit https://review.coreboot.org/c/coreboot/+/48641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9 Gerrit-Change-Number: 48641 Gerrit-PatchSet: 5 Gerrit-Owner: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Will Lee wwlee@google.com Gerrit-MessageType: merged

1386

days inactive

1392

days old

coreboot-gerrit@coreboot.org

11 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Hung-Te Lin (Code Review)
Karthik Ramasubramanian (Code Review)
Rasheed Hsueh (Code Review)
rasheed.hsueh (Code Review)