build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util: Add amdfwread utility ......................................................................
Patch Set 1:
(3 comments)
File util/amdfwread/amdfwread.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143929): https://review.coreboot.org/c/coreboot/+/62795/comment/189ed88d_e4c81dd8 PS1, Line 268: void print_usage() Bad function definition - void print_usage() should probably be void print_usage(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143929): https://review.coreboot.org/c/coreboot/+/62795/comment/0b0dbfba_9d99ea16 PS1, Line 315: for (size_t i = 0; i < sizeof(fw_header_offsets) / sizeof(fw_header_offsets[0]); i++) { Prefer ARRAY_SIZE(fw_header_offsets)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143929): https://review.coreboot.org/c/coreboot/+/62795/comment/0f320840_6509dae0 PS1, Line 334: } adding a line without newline at end of file