Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Jérémy Compostella.
Hello Intel coreboot Reviewers, Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87085?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Jérémy Compostella, Verified+1 by build bot (Jenkins)
Change subject: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source ......................................................................
drivers/intel/touch: Conditionally add ACPI _PRW based on wake source
This change addresses an issue in the touch driver where the ACPI _PRW method was added unconditionally. The ACPI _PRW method should only be generated when an Interrupt() resource is used in the _CRS method. When a GpioInt() resource is used instead, the _PRW method is not required.
The ACPI generation code has been updated to conditionally add the _PRW method based on whether the wake source is a GPIO interrupt or an IRQ interrupt. Now, the _PRW method is only added when an IRQ pin is specified, which is consistent with ACPI requirements.
BUG=none TEST=Configure the DRIVERS_INTEL_TOUCH option on a motherboard that has the necessary touch configurations with wake support. Verify that the THC ACPI tables are correctly generated in the SSDT.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6 --- M src/drivers/intel/touch/touch.c 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/87085/2