Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74712?usp=email )
Change subject: soc/amd/picasso/chip: use common data fabric domain resource code
......................................................................
Patch Set 19: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74712/comment/e140f1c0_968a76bf :
PS19, Line 107: reboot
lol, what!?
File src/soc/amd/picasso/acpi/sb_pci0_fch.asl:
https://review.coreboot.org/c/coreboot/+/74712/comment/fb50291b_d643d27e :
PS19, Line 27: CRES
So glad to see all of this code gone!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia24930ec2a9962dd15e874e9defea441cffae9f2
Gerrit-Change-Number: 74712
Gerrit-PatchSet: 19
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 16:43:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment