Attention is currently required from: Alicja Michalska, Benjamin Doron, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan, Matt DeVillier.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series
......................................................................
Patch Set 10:
(3 comments)
Patchset:
PS9:
good idea. […]
I mean, the main thing from CB:84213 that is not in this change is the vboot stuff. I can look into adding this in tomorrow.
File src/mainboard/hardkernel/odroid-h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/83979/comment/545d0477_72a11b9f?usp... :
PS9, Line 18: select USE_LEGACY_8254_TIMER
I don't remember why it was selected, but I can remove it.
Done
File src/mainboard/hardkernel/odroid-h4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/41e44173_efe89602?usp... :
PS9, Line 13: ite_reg_write(GPIO_DEV, 0x26, 0xfb);
: ite_reg_write(GPIO_DEV, 0x29, 0x01);
: ite_reg_write(GPIO_DEV, 0x2c, 0x41);
: ite_reg_write(GPIO_DEV, 0x2d, 0x02);
: ite_reg_write(GPIO_DEV, 0xbc, 0xc0);
: ite_reg_write(GPIO_DEV, 0xbd, 0x03);
: ite_reg_write(GPIO_DEV, 0xc1, 0x0a);
: ite_reg_write(GPIO_DEV, 0xc8, 0x00);
: ite_reg_write(GPIO_DEV, 0xc9, 0x0a);
: ite_reg_write(GPIO_DEV, 0xda, 0xb0);
: ite_reg_write(GPIO_DEV, 0xdb, 0x44);
Not really. This sets up the Super I/O GPIOs, and the values come from vendor firmware. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 10
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 20:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com