Change in coreboot[master]: [WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: [WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
[WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally
Change-Id: I11b02cc5f8b59559443329fe0c49a6fb82b7862a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/poppy/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/41726/1
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 8553821..74b4da6 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -174,7 +174,7 @@ config VARIANT_SPECIFIC_OPTIONS_NOCTURNE def_bool n select CHROMEOS_WIFI_SAR if CHROMEOS - select DRIVERS_I2C_SX9310 if CHROMEOS_WIFI_SAR + select DRIVERS_I2C_SX9310 select DRIVERS_I2C_MAX98373 select DRIVERS_I2C_DA7219 select DRIVERS_SPI_ACPI
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: [WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG@7 PS4, Line 7: Add SX9310 driver unconditionally Please add explanation as to why this is needed. Is there a bug that this change is fixing?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: [WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG@7 PS4, Line 7: Add SX9310 driver unconditionally
Please add explanation as to why this is needed. […]
CB:35086. I don't know the correct fix so completing this one (including the commit message) would be just quessing and wasting time.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: [WIP] mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41726
to look at the new patch set (#5).
Change subject: mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
mb/google/poppy-nocturne: Add SX9310 driver unconditionally
Change-Id: I11b02cc5f8b59559443329fe0c49a6fb82b7862a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/poppy/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/41726/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
Patch Set 5: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41726/4//COMMIT_MSG@7 PS4, Line 7: Add SX9310 driver unconditionally
CB:35086. […]
It's now documented in gerrit review. Other similar changes went in without explanations and reviewer did not return with objections.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41726 )
Change subject: mb/google/poppy-nocturne: Add SX9310 driver unconditionally ......................................................................
mb/google/poppy-nocturne: Add SX9310 driver unconditionally
Change-Id: I11b02cc5f8b59559443329fe0c49a6fb82b7862a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41726 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 8553821..74b4da6 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -174,7 +174,7 @@ config VARIANT_SPECIFIC_OPTIONS_NOCTURNE def_bool n select CHROMEOS_WIFI_SAR if CHROMEOS - select DRIVERS_I2C_SX9310 if CHROMEOS_WIFI_SAR + select DRIVERS_I2C_SX9310 select DRIVERS_I2C_MAX98373 select DRIVERS_I2C_DA7219 select DRIVERS_SPI_ACPI
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Nick Vaccaro (Code Review)
-
Nico Huber (Code Review)