Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar()
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
I wonder why baytrail uses a different prepare_and_run_postcar() function.
https://review.coreboot.org/c/coreboot/+/34808/7/src/soc/intel/baytrail/roms...
File src/soc/intel/baytrail/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/7/src/soc/intel/baytrail/roms...
PS7, Line 56: prepare_postcar
Minor: prepare_and_run_postcar ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0418a2abc74f749203c587b2763c5f8a5960e4f9
Gerrit-Change-Number: 34808
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment