Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Sandeep Maheswaram has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56091 )
Change subject: soc/qualcomm/common/usb: Add support for common USB driver ......................................................................
Patch Set 40:
(9 comments)
File src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h:
https://review.coreboot.org/c/coreboot/+/56091/comment/034497ef_835389c2 PS38, Line 15:
Don't put random blank lines in struct definitions.
Done
File src/soc/qualcomm/common/include/soc/usb/qusb_phy.h:
https://review.coreboot.org/c/coreboot/+/56091/comment/3b8c2d79_2db198a3 PS38, Line 43: //#define USB3_PCS_PHYSTATUS BIT(6)
No commented-out code
Done
File src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h:
https://review.coreboot.org/c/coreboot/+/56091/comment/c8280eec_cfb5a0af PS38, Line 14:
spurious newline
Done
File src/soc/qualcomm/common/usb/qmpv3_usb_phy.c:
https://review.coreboot.org/c/coreboot/+/56091/comment/dd00f2d0_7c453323 PS38, Line 358: = {
Don't put the = on a new line.
Done
File src/soc/qualcomm/common/usb/qmpv4_usb_phy.c:
https://review.coreboot.org/c/coreboot/+/56091/comment/0d21f461_7be8a753 PS38, Line 352: = {
same
Done
File src/soc/qualcomm/common/usb/qusb_phy.c:
https://review.coreboot.org/c/coreboot/+/56091/comment/6ae7fab6_2de608be PS38, Line 6: void hs_usb_phy_init(void *board_data);
This prototype is already in usb_common.h, just include that instead.
Done
https://review.coreboot.org/c/coreboot/+/56091/comment/89018a2e_4f28bf10 PS38, Line 11:
same here
Done
https://review.coreboot.org/c/coreboot/+/56091/comment/8ff8fba8_2339ed1e PS38, Line 27:
Please try to be somewhat consistent with the continuation line indentation.
Done
File src/soc/qualcomm/common/usb/snps_usb_phy.c:
https://review.coreboot.org/c/coreboot/+/56091/comment/2a318331_e428fe4f PS38, Line 33: void hs_usb_phy_init(void *board_data);
same here
Done
-
Sandeep Maheswaram (Code Review)